Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade project deps to latest; use semver, not wildcard nor tilde #494

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

jpschorr
Copy link
Contributor

@jpschorr jpschorr commented Sep 6, 2024


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jpschorr jpschorr changed the base branch from main to dev-ion-doc September 6, 2024 19:41
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.49%. Comparing base (83efb7f) to head (fdd7148).
Report is 1 commits behind head on dev-ion-doc.

Additional details and impacted files
@@             Coverage Diff              @@
##           dev-ion-doc     #494   +/-   ##
============================================
  Coverage        80.49%   80.49%           
============================================
  Files               73       73           
  Lines            18947    18947           
  Branches         18947    18947           
============================================
  Hits             15251    15251           
  Misses            3271     3271           
  Partials           425      425           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jpschorr jpschorr force-pushed the dev-ion-doc-chore-upgrade- branch from 08992ad to fdd7148 Compare September 6, 2024 20:03
@jpschorr jpschorr requested a review from am357 September 6, 2024 20:06
Copy link

github-actions bot commented Sep 6, 2024

Conformance comparison report

Base (83efb7f) 63c2324 +/-
% Passing 90.35% 90.35% 0.00%
✅ Passing 5731 5731 0
❌ Failing 612 612 0
🔶 Ignored 0 0 0
Total Tests 6343 6343 0

Number passing in both: 5731

Number failing in both: 612

Number passing in Base (83efb7f) but now fail: 0

Number failing in Base (83efb7f) but now pass: 0

@jpschorr jpschorr requested a review from alancai98 September 6, 2024 20:17
deny.toml Show resolved Hide resolved
@jpschorr jpschorr merged commit 7a8a028 into dev-ion-doc Sep 17, 2024
19 checks passed
@jpschorr jpschorr deleted the dev-ion-doc-chore-upgrade- branch September 17, 2024 20:21
jpschorr added a commit that referenced this pull request Sep 17, 2024
* Rename `ion-rs` to `ion-rs_old` in preparation of upgrade (#492)

* Refactor lexer into module & upgrade lexer & parser dependencies (#493)

* Upgrade project deps to latest; use semver, not wildcard nor tilde (#494)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants