-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Use list pull request files api #54
Merged
pascalgn
merged 4 commits into
pascalgn:main
from
levsa:fix/use_list_pull_request_files
Aug 25, 2024
Merged
fix: Use list pull request files api #54
pascalgn
merged 4 commits into
pascalgn:main
from
levsa:fix/use_list_pull_request_files
Aug 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levsa
force-pushed
the
fix/use_list_pull_request_files
branch
from
July 19, 2024 07:15
8005bac
to
7b85c60
Compare
subhamg
approved these changes
Jul 20, 2024
levsa
commented
Jul 23, 2024
index.js
Outdated
Comment on lines
171
to
172
console.log(typeof(pullRequestFiles)); | ||
console.log(pullRequestFiles); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll remove these leftovers.
and sum the changes for each file instead of parsing diff to solve the issue with max 300 files error from rest api.
levsa
force-pushed
the
fix/use_list_pull_request_files
branch
from
July 23, 2024 09:27
7b85c60
to
dba23cd
Compare
joellidin
approved these changes
Aug 5, 2024
Hey, what's the status here? can it be merged? |
and sum the changes for each file instead of parsing diff to solve the issue with max 300 files error from rest api.
and sum the changes for each file instead of parsing diff to solve the issue with max 300 files error from rest api.
and sum the changes for each file instead of parsing diff to solve the issue with max 300 files error from rest api.
Fixes #53 |
Thanks for the PR, it's merged now! 👍 |
bloopy-boi bot
referenced
this pull request
in h3mmy/bloopyboi
Aug 25, 2024
….4 ) (#410) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [pascalgn/size-label-action](https://github.com/pascalgn/size-label-action) | action | patch | `v0.5.2` -> `v0.5.4` | --- ### Release Notes <details> <summary>pascalgn/size-label-action (pascalgn/size-label-action)</summary> ### [`v0.5.4`](https://github.com/pascalgn/size-label-action/releases/tag/v0.5.4): Release 0.5.4 [Compare Source](https://github.com/pascalgn/size-label-action/compare/v0.5.3...v0.5.4) #### What's Changed - Add HTTPS proxy support by [@​donovanmuller](https://github.com/donovanmuller) in [https://github.com/pascalgn/size-label-action/pull/28](https://github.com/pascalgn/size-label-action/pull/28) #### New Contributors - [@​donovanmuller](https://github.com/donovanmuller) made their first contribution in [https://github.com/pascalgn/size-label-action/pull/28](https://github.com/pascalgn/size-label-action/pull/28) **Full Changelog**: pascalgn/size-label-action@v0.5.3...v0.5.4 ### [`v0.5.3`](https://github.com/pascalgn/size-label-action/releases/tag/v0.5.3): Release 0.5.3 [Compare Source](https://github.com/pascalgn/size-label-action/compare/v0.5.2...v0.5.3) #### What's Changed - fix: Use list pull request files api by [@​levsa](https://github.com/levsa) in [https://github.com/pascalgn/size-label-action/pull/54](https://github.com/pascalgn/size-label-action/pull/54) #### New Contributors - [@​levsa](https://github.com/levsa) made their first contribution in [https://github.com/pascalgn/size-label-action/pull/54](https://github.com/pascalgn/size-label-action/pull/54) **Full Changelog**: pascalgn/size-label-action@v0.5.2...v0.5.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41Mi4xIiwidXBkYXRlZEluVmVyIjoiMzguNTIuMSIsInRhcmdldEJyYW5jaCI6ImRldiIsImxhYmVscyI6WyJyZW5vdmF0ZS9naXRodWItYWN0aW9uIiwicmVub3ZhdGUvZ2l0aHViLXJlbGVhc2UiLCJ0eXBlL3BhdGNoIl19--> Co-authored-by: bloopy-boi[bot] <98279278+bloopy-boi[bot]@users.noreply.github.com>
mat3e
added a commit
to mat3e/size-label-action
that referenced
this pull request
Oct 4, 2024
Seems since using files API in pascalgn#54, `IGNORED` stopped to work
mat3e
added a commit
to mat3e/size-label-action
that referenced
this pull request
Oct 4, 2024
Seems since using files API in pascalgn#54, `IGNORED` stopped to work
mat3e
added a commit
to mat3e/size-label-action
that referenced
this pull request
Oct 4, 2024
Seems since using files API in pascalgn#54, `IGNORED` stopped to work
mat3e
added a commit
to mat3e/size-label-action
that referenced
this pull request
Oct 4, 2024
Seems since using files API in pascalgn#54, `IGNORED` stopped to work
mat3e
added a commit
to mat3e/size-label-action
that referenced
this pull request
Oct 4, 2024
Seems since using files API in pascalgn#54, `IGNORED` stopped to work
Merged
pascalgn
added a commit
that referenced
this pull request
Oct 23, 2024
* Fix ignored paths check Seems since using files API in #54, `IGNORED` stopped to work * Add test checking undefined path * Add test checking undefined path --------- Co-authored-by: Pascal <pascal.gruen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and sum the changes for each file instead of parsing diff to solve the issue with max 300 files error from rest api.
Probably also solves #53 ?