Skip to content

Commit

Permalink
[MAINTENANCE] Remove "mostly" from "bobster" test config (great-expec…
Browse files Browse the repository at this point in the history
…tations#2996)

* Remove mostly from bobster test fixture and minor cleanup.
  • Loading branch information
alexsherstinsky authored and gipaetusb committed Jul 13, 2021
1 parent a7b8b22 commit 34ed61b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 8 deletions.
6 changes: 1 addition & 5 deletions tests/rule_based_profiler/bobster_user_workflow_fixture.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,6 @@

@pytest.fixture
def bobster_columnar_table_multi_batch_normal_mean_5000_stdev_1000():
"""
# TODO: <Alex>ALEX -- Add DocString</Alex>
"""

verbose_profiler_config_file_path: str = file_relative_path(
__file__, "bobster_user_workflow_verbose_profiler_config.yml"
)
Expand All @@ -25,7 +21,7 @@ def bobster_columnar_table_multi_batch_normal_mean_5000_stdev_1000():
5000
)
my_row_count_range_rule_expect_table_row_count_to_be_between_expectation_std_value: float = (
4.00e2
1.0e3
)
my_row_count_range_rule_expect_table_row_count_to_be_between_expectation_num_stds: float = (
3.00
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,7 @@ variables:
data_asset_name: my_reports
data_connector_query:
index: ":-1"
confidence_level: 9.75e-1
mostly: 1.0
confidence_level: 9.5e-1

rules:
row_count_range_rule:
Expand All @@ -30,6 +29,5 @@ rules:
module_name: great_expectations.rule_based_profiler.expectation_configuration_builder
min_value: $parameter.row_count_range.value.min_value
max_value: $parameter.row_count_range.value.max_value
mostly: $variables.mostly
meta:
profiler_details: $parameter.row_count_range.details

0 comments on commit 34ed61b

Please sign in to comment.