Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PC-34611)[API] chore: remove pro attributes: DEPARTMENT_CODE, POSTAL_CODE (Brevo) #16331

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

prouzet-pass
Copy link
Contributor

But de la pull request

Ticket Jira : https://passculture.atlassian.net/browse/PC-34611

Vérifications

  • J'ai écrit les tests nécessaires
  • J'ai mis à jour le fichier des plans de tests du portail pro si nécessaire
  • J'ai mis à jour la liste des routes et des titres de pages du portail pro si j'en ai rajouté/modifié ou supprimé une.
  • J'ai relu attentivement les migrations, en particulier pour éviter les locks, et je préviens les équipes Shérif et Data
  • J'ai ajouté des screenshots pour d'éventuels changements graphiques
  • J'ai fait la revue fonctionnelle de mon ticket

@prouzet-pass prouzet-pass force-pushed the pc-34611-remove-department-and-postal-code-pro-attributes branch 3 times, most recently from 62ce4dc to 6b37009 Compare February 13, 2025 15:49
…T_CODE, POSTAL_CODE

Now addresses are linked to offers and these attributes do no longer
contain the list of places where the offerer operates. Not used by the
marketing team, so removed until new specification when the information
becomes useful.
@prouzet-pass prouzet-pass force-pushed the pc-34611-remove-department-and-postal-code-pro-attributes branch from 6b37009 to 69079ef Compare February 13, 2025 16:38
Copy link
Contributor

@lmaubert-pass lmaubert-pass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est bon pour moi ! =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants