Skip to content
This repository has been archived by the owner on Mar 10, 2022. It is now read-only.

Shared folder without symlink #77

Closed
wants to merge 1 commit into from
Closed

Conversation

augnustin
Copy link
Contributor

import { requestData } from 'shared/reducers/data' au lieu de import { requestData } from 'pass-culture-shared' que je trouve beaucoup plus confusant.

@augnustin
Copy link
Contributor Author

Je stocke ça là en cas de besoin, on n'est pas obligé de merger tout de suite. Cela dépendra notamment de ce qui se dit ici:

facebook/create-react-app#834 (comment)

@Ledoux
Copy link
Contributor

Ledoux commented Jul 16, 2018

ok cool! Let's see!

@Ledoux
Copy link
Contributor

Ledoux commented Jul 31, 2018

cool, mais le alias demande aussi au build time de faire du compile.

Comme maintenant on utilise aussi pass-culture-shared en ci directement comme un package downloade du registry, on converge vers la solution node_modules et symlink pour le dev de shared

@Ledoux Ledoux closed this Jul 31, 2018
@edupedup edupedup deleted the shared-without-symlink branch June 17, 2019 13:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants