Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend error handler to modals #327

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Conversation

keeshux
Copy link
Member

@keeshux keeshux commented Jul 6, 2023

Alert was not appearing in modals, because it must be explicitly attached to NavigationView.

@keeshux keeshux added the bug Something isn't working label Jul 6, 2023
@keeshux keeshux added this to the 2.2.0 milestone Jul 6, 2023
@keeshux keeshux self-assigned this Jul 6, 2023
@keeshux keeshux added regression Used to work but doesn't anymore and removed bug Something isn't working labels Jul 6, 2023
@keeshux keeshux merged commit a7ea010 into master Jul 6, 2023
1 check passed
@keeshux keeshux deleted the bugfix/global-alert-not-appearing branch July 6, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression Used to work but doesn't anymore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant