Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve some in-app tests #484

Merged
merged 11 commits into from
Jan 20, 2024
Merged

Improve some in-app tests #484

merged 11 commits into from
Jan 20, 2024

Conversation

keeshux
Copy link
Member

@keeshux keeshux commented Jan 20, 2024 •
edited
Loading

A few things:

  • One feature eligibility test was incorrect, namely test_givenFreeVersion_thenIsNotEligibleForAnyFeature
  • Eligibility tests of feature subsets must also assert ineligibility of excluded features
  • App type was not covered

Also add and test a new .fullVersionPlusTV app type including the .appleTV feature.

@keeshux keeshux self-assigned this Jan 20, 2024
@keeshux keeshux added the refactoring Improves software architecture label Jan 20, 2024
@keeshux keeshux added this to the Test in-app purchases milestone Jan 20, 2024
@keeshux keeshux merged commit ef0ac50 into master Jan 20, 2024
@keeshux keeshux deleted the refactoring/inapp-tests branch January 20, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@keeshux keeshux

Labels
refactoring Improves software architecture
Projects
2024 Q1-Q4 Passepartout v3
Status: Done
Milestone
Test in-app purchases
Development

Successfully merging this pull request may close these issues.
1 participant
@keeshux