Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Late dismissal after changing active provider server #804

Merged
merged 3 commits into from
Nov 3, 2024

Conversation

keeshux
Copy link
Member

@keeshux keeshux commented Nov 3, 2024

The dismissal action waited until the current connection was disconnected.

Consider that AppContext makes the explicit .connect() redundant, reconnection is already happening after saving a profile while connected.

@keeshux keeshux self-assigned this Nov 3, 2024
@keeshux keeshux added the bug Something isn't working label Nov 3, 2024
@keeshux keeshux changed the title Late dismiss after selecting provider server while connected Late dismissal after selecting provider server while connected Nov 3, 2024
@keeshux keeshux changed the title Late dismissal after selecting provider server while connected Late dismissal after switching active provider server Nov 3, 2024
@keeshux keeshux changed the title Late dismissal after switching active provider server Late dismissal after changing active provider server Nov 3, 2024
@keeshux keeshux added this to the 3.0.0 / 5. Finalize milestone Nov 3, 2024
@keeshux keeshux merged commit fff21c3 into master Nov 3, 2024
1 check passed
@keeshux keeshux deleted the bugfix/late-vpn-server-dismiss branch November 3, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant