This repository has been archived by the owner on Sep 29, 2024. It is now read-only.
Encapsulate session configuration #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of paths.
For compatible decoding.
Take credentials out of SP.Configuration. Makes sense as they never appear in e.g. an .ovpn file.
keeshux
added
refactoring
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A relevant number of fields in
TunnelKitProvider.Configuration[Builder]is a 1:1 duplicate ofSessionProxy.Configuration[Builder]. The original reason was a mismatch between inline PEMs (AppExtension) and paths to them (Core), as per OpenSSL requirement.This PR:
Coretoo to resolve the content/path mismatch. Persists PEMs to a cache in the app group container (OpenSSL needs file paths to certs/keys).AppExtensionthose fields belonging to theCorearea of the library (e.g. cipher, digest).SessionProxy.ConfigurationinTunnelKitProvider.Configurationvia composition.SessionProxy.Configuration, which also prevents accidental persistence.