Fix: Use in-place edit option that works for Linux, macOS, and OpenBSD #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wouldn't it be more natural to call the backup something like What do you think about this? https://github.com/passff/passff-host/issues/5#issuecomment-377709755 |
Signed-off-by: Wenxuan Zhao <viz@linux.com>
|
The idea is to set backup extension to empty in order to prevent generating backup file, only macOS work in different way. |
|
Okay, looks reasonable now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #5 and #6, and I have tested working on Linux (GNUsedon Ubuntu), macOS (both BSD/usr/bin/sedandgnu-sedfrombrew), and OpenBSD (see https://github.com/passff/passff-host/issues/5#issuecomment-377656095)This should fix #5, and #6 can be fixed with #10