Fix stdin test #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuxor1337
reviewed
Mar 25, 2018
src/passff.py
Outdated
| @@ -14,14 +14,14 @@ | |||
| ################################################################################ | |||
| # Default command for MacOS: | |||
| #command = "/usr/local/bin/pass" | |||
There was a problem hiding this comment.
Please uppercase command -> COMMAND also in this line for Mac users.
tuxor1337
reviewed
Mar 25, 2018
| 'stdout': subprocess.PIPE, | ||
| 'stderr': subprocess.PIPE, | ||
| 'env': env | ||
| } | ||
| if 'stdin' is not None: |
|
Force-update done. |
|
This is not urgent, right? Because it's working for me even without this fix. |
|
Not urgent at all. I am sorry for the misunderstanding. If I'm correct, the code would always create a pipe for stdin, even when the code was not giving any input to Thanks for the merge 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a fix of a typo in the code.
When editing, I noticed I could improve the code, thus the rewrite. Using run() is the recommended approach according to Python.org. It requires Python >= 3.5 (released in November 2015).
I have also renamed the pref variables to uppercase since they are constants.
This change highlights the difference between the pref variables &
the other variables in the code.