Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add installer support for gopass #61

Merged
merged 1 commit into from Dec 3, 2022
Merged

Add installer support for gopass #61

merged 1 commit into from Dec 3, 2022

Conversation

ghost
Copy link

@ghost ghost commented Dec 3, 2022

gopass support was previously added, but gopass doesn't support using the show command to show the directory list anymore. The ls command works with both pass and gopass.

The installer can also work if only gopass is installed.

@ghost ghost changed the title Add gopass support Add installer support for gopass Dec 3, 2022
@ghost
Copy link
Author

ghost commented Dec 3, 2022

Sorry, gopass show / actually does work, so I undid the previous change.

gopass sometimes doesn't work with passff, so I thought that was the problem but it isn't...

@tuxor1337
Copy link
Contributor

tuxor1337 commented Dec 3, 2022

Thanks for your contribution!

If it "sometimes doesn't work with passff", I'm a bit reluctant to add it to the README as officially supported. That might end up in a surge of users complaining about things like https://github.com/passff/passff/issues/400

@ghost
Copy link
Author

ghost commented Dec 3, 2022

Fair point!
I've updated the PR so it doesn't add anything to the README

@tuxor1337 tuxor1337 merged commit 8fcae33 into passff:master Dec 3, 2022
@ghost ghost deleted the gopass branch December 4, 2022 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant