Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript migration #743

Closed
wants to merge 20 commits into from
Closed

Conversation

lit26
Copy link

@lit26 lit26 commented Jan 11, 2023

Add typescript migration for the frontend

@pastelsky
Copy link
Owner

Thanks for the pull request @lit26 — really appreciate the time you took to create this. But it looks like this PR also refactors class components to functional components, and makes other logic changes at a few places.

Due to this —

  1. We would lose git history for existing files since these aren't detected as renames
  2. It is difficult to review since the diffs are not very meaningful and there are quite a changes occuring at the same time.

I'd request sharding the changes, and do them one at a time —

  1. Just the TS migration.
  2. Class -> function components
  3. Any other logic changes / fixes

@lit26
Copy link
Author

lit26 commented Feb 25, 2023

Will do. Can I switch step 1 and 2? A little bit easier for me.

@lit26
Copy link
Author

lit26 commented Feb 27, 2023

Split steps in other PR.

@lit26 lit26 closed this Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants