Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inject event dispatcher to worker #685

Merged
merged 4 commits into from
Feb 5, 2025

Conversation

DanielBadura
Copy link
Member

@DanielBadura DanielBadura commented Feb 5, 2025

This enables to write custom listener for the subscription engine worker events.

@DanielBadura DanielBadura marked this pull request as ready for review February 5, 2025 14:37
@DanielBadura DanielBadura self-assigned this Feb 5, 2025
@DanielBadura DanielBadura added the enhancement New feature or request label Feb 5, 2025
@DanielBadura DanielBadura added this to the 3.9.0 milestone Feb 5, 2025
Copy link

github-actions bot commented Feb 5, 2025

Hello 👋

here is the most recent benchmark result:

SubscriptionEngineBench
=======================

+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                               | memory                                     |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>  | Tag: base       | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 3.173s (±0.00%) | 3.170s (±0.00%) | +0.09%    | 46.745mb        | 47.257mb   | -1.08%      |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+

SubscriptionEngineBatchBench
============================

+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                                   | memory                                     |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>    | Tag: base         | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 75.444ms (±0.00%) | 75.048ms (±0.00%) | +0.53%    | 34.597mb        | 34.597mb   | 0.00%       |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+

PersonalDataBench
=================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 862.400μs (±0.00%) | 868.700μs (±0.00%) | -0.73%    | 35.258mb        | 35.258mb   | 0.00%       |
| benchLoad10000Events ()                | 86.244ms (±0.00%)  | 89.528ms (±0.00%)  | -3.67%    | 35.258mb        | 35.258mb   | 0.00%       |
| benchSave1Event ()                     | 1.537ms (±0.00%)   | 1.935ms (±0.00%)   | -20.57%   | 35.258mb        | 35.258mb   | 0.00%       |
| benchSave10000Events ()                | 250.237ms (±0.00%) | 255.388ms (±0.00%) | -2.02%    | 35.259mb        | 35.259mb   | 0.00%       |
| benchSave10000Aggregates ()            | 13.327s (±0.00%)   | 13.139s (±0.00%)   | +1.43%    | 35.258mb        | 35.258mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 9.079s (±0.00%)    | 9.028s (±0.00%)    | +0.57%    | 35.759mb        | 35.759mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SimpleSetupBench
================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 977.800μs (±0.00%) | 970.500μs (±0.00%) | +0.75%    | 34.128mb        | 34.128mb   | 0.00%       |
| benchLoad10000Events ()                | 51.749ms (±0.00%)  | 51.839ms (±0.00%)  | -0.17%    | 34.128mb        | 34.128mb   | 0.00%       |
| benchSave1Event ()                     | 1.523ms (±0.00%)   | 1.033ms (±0.00%)   | +47.36%   | 34.128mb        | 34.128mb   | 0.00%       |
| benchSave10000Events ()                | 219.154ms (±0.00%) | 217.662ms (±0.00%) | +0.69%    | 34.128mb        | 34.128mb   | 0.00%       |
| benchSave10000Aggregates ()            | 8.910s (±0.00%)    | 8.906s (±0.00%)    | +0.04%    | 34.128mb        | 34.128mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 4.902s (±0.00%)    | 4.890s (±0.00%)    | +0.25%    | 34.128mb        | 34.128mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SimpleSetupStreamStoreBench
===========================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 998.900μs (±0.00%) | 992.500μs (±0.00%) | +0.64%    | 34.242mb        | 34.242mb   | 0.00%       |
| benchLoad10000Events ()                | 56.661ms (±0.00%)  | 56.808ms (±0.00%)  | -0.26%    | 34.242mb        | 34.242mb   | 0.00%       |
| benchSave1Event ()                     | 1.165ms (±0.00%)   | 1.203ms (±0.00%)   | -3.17%    | 34.242mb        | 34.242mb   | 0.00%       |
| benchSave10000Events ()                | 297.410ms (±0.00%) | 293.158ms (±0.00%) | +1.45%    | 34.242mb        | 34.242mb   | 0.00%       |
| benchSave10000Aggregates ()            | 9.038s (±0.00%)    | 9.113s (±0.00%)    | -0.82%    | 34.242mb        | 34.242mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 5.087s (±0.00%)    | 5.097s (±0.00%)    | -0.19%    | 34.242mb        | 34.242mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SnapshotsBench
==============

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad10000EventsMissingSnapshot () | 50.386ms (±0.00%)  | 50.427ms (±0.00%)  | -0.08%    | 34.132mb        | 34.132mb   | 0.00%       |
| benchLoad10000Events ()                | 913.600μs (±0.00%) | 924.200μs (±0.00%) | -1.15%    | 34.132mb        | 34.132mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SplitStreamBench
================

+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                         | time (kde mode)                                     | memory                                     |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                 | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad10000Events () | 4.454ms (±0.00%)   | 4.461ms (±0.00%)   | -0.14%    | 37.435mb        | 37.435mb   | 0.00%       |
| benchSave10000Events () | 339.876ms (±0.00%) | 343.509ms (±0.00%) | -1.06%    | 37.506mb        | 37.506mb   | 0.00%       |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

This comment gets update everytime a new commit comes in!

@DanielBadura DanielBadura force-pushed the inject-event-dispatcher-to-worker branch from 932a185 to c4676c7 Compare February 5, 2025 14:45
@DanielBadura DanielBadura merged commit b767ff2 into 3.9.x Feb 5, 2025
35 of 36 checks passed
@DanielBadura DanielBadura deleted the inject-event-dispatcher-to-worker branch February 5, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants