Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use reflection for accessing child aggregates, add test case which covers private child aggregates #687

Merged
merged 3 commits into from
Feb 7, 2025

Conversation

DanielBadura
Copy link
Member

No description provided.

@DanielBadura DanielBadura linked an issue Feb 6, 2025 that may be closed by this pull request
Copy link

github-actions bot commented Feb 6, 2025

Hello 👋

here is the most recent benchmark result:

SubscriptionEngineBench
=======================

+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                               | memory                                     |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>  | Tag: base       | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 3.141s (±0.00%) | 3.141s (±0.00%) | +0.03%    | 46.745mb        | 47.257mb   | -1.08%      |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+

SubscriptionEngineBatchBench
============================

+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                                   | memory                                     |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>    | Tag: base         | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 76.647ms (±0.00%) | 76.068ms (±0.00%) | +0.76%    | 34.597mb        | 34.597mb   | 0.00%       |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+

PersonalDataBench
=================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 848.000μs (±0.00%) | 854.500μs (±0.00%) | -0.76%    | 35.258mb        | 35.258mb   | 0.00%       |
| benchLoad10000Events ()                | 88.310ms (±0.00%)  | 89.324ms (±0.00%)  | -1.14%    | 35.258mb        | 35.258mb   | 0.00%       |
| benchSave1Event ()                     | 1.517ms (±0.00%)   | 1.747ms (±0.00%)   | -13.19%   | 35.258mb        | 35.258mb   | 0.00%       |
| benchSave10000Events ()                | 243.005ms (±0.00%) | 249.921ms (±0.00%) | -2.77%    | 35.259mb        | 35.259mb   | 0.00%       |
| benchSave10000Aggregates ()            | 12.507s (±0.00%)   | 13.017s (±0.00%)   | -3.91%    | 35.258mb        | 35.258mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 8.970s (±0.00%)    | 8.951s (±0.00%)    | +0.22%    | 35.759mb        | 35.759mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SimpleSetupBench
================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 938.700μs (±0.00%) | 950.000μs (±0.00%) | -1.19%    | 34.128mb        | 34.128mb   | 0.00%       |
| benchLoad10000Events ()                | 50.066ms (±0.00%)  | 50.134ms (±0.00%)  | -0.14%    | 34.128mb        | 34.128mb   | 0.00%       |
| benchSave1Event ()                     | 895.500μs (±0.00%) | 926.300μs (±0.00%) | -3.33%    | 34.128mb        | 34.128mb   | 0.00%       |
| benchSave10000Events ()                | 216.685ms (±0.00%) | 215.222ms (±0.00%) | +0.68%    | 34.128mb        | 34.128mb   | 0.00%       |
| benchSave10000Aggregates ()            | 8.827s (±0.00%)    | 7.708s (±0.00%)    | +14.52%   | 34.128mb        | 34.128mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 4.828s (±0.00%)    | 4.838s (±0.00%)    | -0.20%    | 34.128mb        | 34.128mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SimpleSetupStreamStoreBench
===========================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 951.400μs (±0.00%) | 993.000μs (±0.00%) | -4.19%    | 34.242mb        | 34.242mb   | 0.00%       |
| benchLoad10000Events ()                | 57.927ms (±0.00%)  | 55.107ms (±0.00%)  | +5.12%    | 34.242mb        | 34.242mb   | 0.00%       |
| benchSave1Event ()                     | 1.225ms (±0.00%)   | 1.076ms (±0.00%)   | +13.86%   | 34.242mb        | 34.242mb   | 0.00%       |
| benchSave10000Events ()                | 286.112ms (±0.00%) | 287.968ms (±0.00%) | -0.64%    | 34.242mb        | 34.242mb   | 0.00%       |
| benchSave10000Aggregates ()            | 10.541s (±0.00%)   | 8.413s (±0.00%)    | +25.30%   | 34.242mb        | 34.242mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 5.041s (±0.00%)    | 5.045s (±0.00%)    | -0.07%    | 34.242mb        | 34.242mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SnapshotsBench
==============

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad10000EventsMissingSnapshot () | 52.388ms (±0.00%)  | 51.938ms (±0.00%)  | +0.87%    | 34.202mb        | 34.132mb   | +0.20%      |
| benchLoad10000Events ()                | 952.900μs (±0.00%) | 925.800μs (±0.00%) | +2.93%    | 34.202mb        | 34.132mb   | +0.20%      |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SplitStreamBench
================

+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                         | time (kde mode)                                     | memory                                     |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                 | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad10000Events () | 4.264ms (±0.00%)   | 4.315ms (±0.00%)   | -1.17%    | 37.435mb        | 37.435mb   | 0.00%       |
| benchSave10000Events () | 333.886ms (±0.00%) | 334.421ms (±0.00%) | -0.16%    | 37.507mb        | 37.507mb   | 0.00%       |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

This comment gets update everytime a new commit comes in!

@DanielBadura DanielBadura marked this pull request as ready for review February 7, 2025 11:37
@DanielBadura DanielBadura self-assigned this Feb 7, 2025
@DanielBadura DanielBadura added the enhancement New feature or request label Feb 7, 2025
@DanielBadura DanielBadura added this to the 3.9.0 milestone Feb 7, 2025
@DanielBadura DanielBadura merged commit d0ea850 into 3.9.x Feb 7, 2025
34 of 36 checks passed
@DanielBadura DanielBadura deleted the use-reflection-for-child-property branch February 7, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[experimental] Child Aggregates
2 participants