added ESM support

[MarkusDeutschmann]

• added ESM support - dist-esm will be created in addition to dist
• removed lodash dependency for easier use of ESM
• because of ESM the static imports needed to be changed - now ending with *.js
• needed to replace ts-prune with unimported as ts-prune does not supporting ESM imports
• updated dependencies

[patik]

Awesome, thank you! Unfortunately I won't have a proper computer available for the next couple weeks to check it over and publish the new version. Hope it's okay to wait.

[patik]

If the result is the same, then yes let’s drop the lodash dependency.

[MarkusDeutschmann]

Thanks, ok I think it won't break anything to remove lodash.
Sure it ok to wait.
I would be happy to not break something but also provide more functionality.

[patik]

If the tests are passing on your end, please bump the version number in package.json and I'll merge it. With any luck, the GitHub action will work and automatically publish it to NPM so you don't need to wait for me to get back to my laptop.

[MarkusDeutschmann]

Thanks.
Here are the result of the test:

• yarn lint:

yarn run v1.22.19
$ yarn workspaces run lint

> withinviewport
$ yarn typecheck && yarn run code-lint && yarn unused-exports
$ tsc --noEmit
$ eslint --ext .ts --fix ./src/**/*.ts
$ unimported --no-cache
✓ There don't seem to be any unimported files.

> @patik/within-viewport-demo
$ yarn typecheck && yarn code-lint && yarn unused-exports
$ tsc --noEmit
$ eslint --ext .ts --fix ./src/**/*.ts
$ unimported --no-cache
✓ There don't seem to be any unimported files.
Done in 10.84s.

• yarn test:

yarn run v1.22.19
$ yarn --cwd module test
$ yarn jest --coverage
$ C:\git_repo\within-viewport\node_modules\.bin\jest --coverage
 PASS  src/tests/specs/strictCallbackAndRootMargin.test.ts
 PASS  src/tests/specs/options.test.ts
------------|---------|----------|---------|---------|-------------------
File        | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s 
------------|---------|----------|---------|---------|-------------------
All files   |   96.66 |    89.65 |     100 |   96.55 |                   
 options.ts |   95.45 |       88 |     100 |   95.45 | 47                
 sides.ts   |     100 |      100 |     100 |     100 |                   
------------|---------|----------|---------|---------|-------------------

Test Suites: 2 passed, 2 total  
Tests:       37 passed, 37 total
Snapshots:   0 total
Time:        3.21 s
Ran all test suites.
Done in 6.74s.

• yarn cover

yarn run v1.22.19
$ yarn --cwd module test --collectCoverage
$ yarn jest --coverage --collectCoverage
$ C:\git_repo\within-viewport\node_modules\.bin\jest --coverage --collectCoverage
 PASS  src/tests/specs/strictCallbackAndRootMargin.test.ts
 PASS  src/tests/specs/options.test.ts
------------|---------|----------|---------|---------|-------------------
File        | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s 
------------|---------|----------|---------|---------|-------------------
All files   |   96.66 |    89.65 |     100 |   96.55 |                   
 options.ts |   95.45 |       88 |     100 |   95.45 | 47                
 sides.ts   |     100 |      100 |     100 |     100 |                   
------------|---------|----------|---------|---------|-------------------

Test Suites: 2 passed, 2 total  
Tests:       37 passed, 37 total
Snapshots:   0 total
Time:        2.625 s
Ran all test suites.
Done in 5.72s.

But no hurry regarding the release. If you want to check by yourself, I understand that. It's no issue to wait a while.

[patik]

Thanks a lot. I will wait then, just in case something goes awry.

[patik]

There were some conflicts with the yarn.lock that needed to be fixed, so I hope it's okay I pushed to your branch.

So far it looks good in terms of passing tests, etc. However I noticed an issue with the tree-shaking. I added this module to another project, imported just { withinviewport }, and ran the Webpack bundle analyzer. It shows that the jQuery plugin is still being included:

Likely this is an issue with the way things are exported from index.ts and is not a problem with your PR. I'll need to look into reconfiguring the exports so that tree-shaking happens properly.

[patik]

@MarkusDeutschmann I managed to get it working so that both CJS and ESM are in the same dist folder and tree-shaking works fine (e.g. when I use this package in another app, the jQuery plugin doesn't get bundled). Please take a look at the recent changes and you can merge it when you're ready.

[MarkusDeutschmann]

Hi @patik Thanks a lot. From my point of view it you change are fine. The only thing that I changed is the postbuild step. I just moved it from the bash script into the package.json script section. Reason is that I would like to prevent the break of local dev builds on Windows systems. I hope this is ok for you.
Changes now merged.

[patik]

@MarkusDeutschmann Looks good Works well on the Mac too.

Thanks again for the PR!

[patik]

Closes #141