-
-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multilanguage parity and ideas for contribution #204
Conversation
Looks good to me @patriciogonzalezvivo ! |
oh great more responsibility 😅🤣 |
Co-authored-by: nobkd <44443899+nobkd@users.noreply.github.com>
Co-authored-by: nobkd <44443899+nobkd@users.noreply.github.com>
Co-authored-by: nobkd <44443899+nobkd@users.noreply.github.com>
Co-authored-by: nobkd <44443899+nobkd@users.noreply.github.com>
Co-authored-by: nobkd <44443899+nobkd@users.noreply.github.com>
Co-authored-by: nobkd <44443899+nobkd@users.noreply.github.com>
Co-authored-by: nobkd <44443899+nobkd@users.noreply.github.com>
Co-authored-by: nobkd <44443899+nobkd@users.noreply.github.com>
@vade I knew I'was asking a lot, take it as a wish upon a star : ) |
Thank you @nobkd for the corrections! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here are some more changes.
ps: you can accept multiple suggestions in one commit by using 'add to batch' (or so) button in the 'files changed' tab :)
Co-authored-by: nobkd <44443899+nobkd@users.noreply.github.com>
Co-authored-by: nobkd <44443899+nobkd@users.noreply.github.com>
Co-authored-by: nobkd <44443899+nobkd@users.noreply.github.com>
Hey sorry I'm a little late to the game here, reviewing now and everything is looking pretty good to me! |
Hi @shadielhajj @vade @sdedovic we were talking about the friction points and frustrations around growing and maintaining a multi-language project like this.
Made this PR with some tooling (the famous script that I promise to prune all other languages. And some changes on de documentation. Particularly the new
CONTRIBUTE.md
so we can start talking and crafting the guidelines. I put you guys as the lead language contributors but if that seems like to much of a responsibility I totally understand it. Feel free to take your name out.Let me know what you think an please make any correction or suggestion you seems fit.
Cheers!