Multilanguage parity and ideas for contribution #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me @patriciogonzalezvivo ! |
shadielhajj
approved these changes
Aug 16, 2024
|
oh great more responsibility 😅🤣 |
nobkd
reviewed
Aug 16, 2024
Co-authored-by: nobkd <44443899+nobkd@users.noreply.github.com>
Co-authored-by: nobkd <44443899+nobkd@users.noreply.github.com>
Co-authored-by: nobkd <44443899+nobkd@users.noreply.github.com>
Co-authored-by: nobkd <44443899+nobkd@users.noreply.github.com>
Co-authored-by: nobkd <44443899+nobkd@users.noreply.github.com>
Co-authored-by: nobkd <44443899+nobkd@users.noreply.github.com>
Co-authored-by: nobkd <44443899+nobkd@users.noreply.github.com>
Co-authored-by: nobkd <44443899+nobkd@users.noreply.github.com>
@vade I knew I'was asking a lot, take it as a wish upon a star : ) |
|
Thank you @nobkd for the corrections! |
nobkd
reviewed
Aug 16, 2024
Co-authored-by: nobkd <44443899+nobkd@users.noreply.github.com>
Co-authored-by: nobkd <44443899+nobkd@users.noreply.github.com>
Co-authored-by: nobkd <44443899+nobkd@users.noreply.github.com>
|
Hey sorry I'm a little late to the game here, reviewing now and everything is looking pretty good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @shadielhajj @vade @sdedovic we were talking about the friction points and frustrations around growing and maintaining a multi-language project like this.
Made this PR with some tooling (the famous script that I promise to prune all other languages. And some changes on de documentation. Particularly the new
CONTRIBUTE.mdso we can start talking and crafting the guidelines. I put you guys as the lead language contributors but if that seems like to much of a responsibility I totally understand it. Feel free to take your name out.Let me know what you think an please make any correction or suggestion you seems fit.
Cheers!