Fix BC-break for combination of PHP 7.4 and lcobucci/jwt 3.4 #25
Conversation
| @@ -3,13 +3,23 @@ language: php | |||
| matrix: | |||
| include: | |||
| - php: 5.6 | |||
| env: LCOBUCCI_JWT_VERSION=^3.4 | |||
There was a problem hiding this comment.
I guess this isn't even necessary because version 4 requires PHP 7.4 and it will install 3.x anyway but I assume it also doesn't hurt to be explicit about it.
There was a problem hiding this comment.
I did it that way, since I had no clue how to do line 54 without it. By the way: I'm also not sure if this works well for the hhvm-builds, but they are failing in an earlier stage at the composer self-update. I don't know how to fix that and at least it's not related to this issue/branch.
|
@patrickbussmann Can you give an indication at which term you can review my PR and (hopefully) merge and release it? |
|
Sorry @tjveldhuizen its only my time. thanks! |
|
No worries, just checking what I can expect :) Thanks in advance |
|
Hi @patrickbussmann, thanks for merging! Can we expect a release soon? |
The specific combination of lcobucci/jwt ^3.4 and php 7.4 failed. The existing scenarios didn't catch that, since ^4.0 is allowed in php 7.4, however in our project some other package is not compatible with ^4.0, which resulted in the failure as mentioned.
Fixes #24