add sub to resource owner toArray() #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We also have the need for this enhancement and find it useful for the same use case of OIDC with Apple. Could this please get merged in and a new release made? |
|
@patrickbussmann Any chance you can merge this and make a release? I have another project that I want to make a release for and it needs this functionality. Thanks for your work on this package. It is very much appreciated. |
|
Ah yea sorry. I'll write down a note and do this soon. (tomorrow or day after latestly) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We make use of toArray() on various oauth2 ResourceOwner implementations and the apple one is missing the
sub(resource owner id) in the resulting array.