-
-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A collection of fixes to allow compilation in a c++11 environment (openFrameworks) #179
Conversation
…p in the interim.
Hey that sounds really cool! Thank you very much! And thank you very much for the PR. I think some of these we can definitely merge, particularly the ones that are fixes! (missing I will have a closer look at the PR next week when I've got a bit more time :) Oh and the roadmap is actually to move away completely from PS: If you don't mind, would you rename "EOS" in your project(s) to "eos"? We usually use the lower-case spelling. :-) That would be awesome! |
Thanks for taking a look! Regarding the CI errors -- we use glm all over openFrameworks, so it must have picked up the glm::clamp function elsewhere. I'll leave it alone though until you take a look. We recently moved everything in openFrameworks from DIY vec/matrix to Regarding C++17, we still only support up to C++11 in openFrameworks since we support so many platforms, so that's our least common denominator (and it took forever to get even there!). I totally understand your perspective though. I'll change my addon name to ofxEos (without the capital, it looks funny next to all of the other openframeworks addons, as they all have a capital after the ofx - http://ofxaddons.com/). I'll refer to it as eos in my readme, links and repos etc. Keep me posted on any bits of the PR you'd like to include. I'm happy to resubmit a clean PR when the time comes. Thanks for sharing the project! |
Hi again :) Thank you for adjusting the name! As you've already seen, I've modified your commits a bit and added the That leaves the auto-return-types and generic lambdas. I'm a bit hesitant to cherry-pick/merge these, as they are C++14 syntax, and eos is a throughout C++14 project. We realised over the last few weeks that we still need to compromise on C++17 and support C++14 - but we definitely don't want to go below that. Particularly as C++14 was more of a "bugfix" release to C++11 and compiler support is very widespread by now. Thank you very much for your input on glm! I totally agree with you. Mostly the Could you please have a quick look at my review-comment above regarding the default template argument (b6f4975)? It strikes me really weird that that's not working and to remove the default argument there. Thank you again and I'll get to the remaining things soon! |
Hi again, it's been a long while! I'm guessing you might not be working on/with ofx-eos anymore? Thank you again for the nice interaction back then, and let me know in case you're still working in the area and would like to discuss anything! |
First, thanks for your work on this. It's really great!
I'm working on an addon that enables openFrameworks users to use this code. Here are some of the updates I had to make to get it running. You can keep track of progress here:
https://github.com/bakercp/ofxEos