Skip to content
This repository has been archived by the owner on Jan 1, 2025. It is now read-only.

Add support for custom source file extensions #92

Merged
merged 3 commits into from
May 8, 2018
Merged

Add support for custom source file extensions #92

merged 3 commits into from
May 8, 2018

Conversation

orta
Copy link
Collaborator

@orta orta commented Aug 9, 2017

I'd like to be able to support TypeScript today, but this feature could mean the special-casing of coffeescript support could be removed as there's enough here to allow anyone to add that support in their own apps easily.

@Igmat
Copy link

Igmat commented Jan 31, 2018

I'm not sure that it would be enough for additional type of transpilers, but it's a good start.
I tried to achieve TS support inside vm by calling pirates inside NodeVM but it seems that require and module can't be affected by script code.

@orta
Copy link
Collaborator Author

orta commented Feb 1, 2018

Good call, I did end up using this in danger-js, but I think moving to pirates is probably what I want to do in the future, thanks!

@orta
Copy link
Collaborator Author

orta commented May 8, 2018

Merging, it's been used in danger in prod for the best part of a year

@orta orta merged commit 8a1dcad into master May 8, 2018
@orta orta deleted the custom_files branch May 8, 2018 11:40
@hmagrini
Copy link

hmagrini commented May 8, 2018

@orta could you restore the custom_files branch? it seems that DangerJS is using that branch as dependency, thus all installations that depend on DangerJS seem to be failing to install.

@orta orta restored the custom_files branch May 8, 2018 12:55
@orta orta deleted the custom_files branch May 8, 2018 12:55
@orta orta restored the custom_files branch May 8, 2018 12:56
@orta
Copy link
Collaborator Author

orta commented May 8, 2018

Heh, I have a tool that auto delete branches, that should keep it running 👍

@hmagrini
Copy link

hmagrini commented May 8, 2018

awesome, thanks for the quick response!

@michaeljacobdavis
Copy link

@patriksimek Would it be possible to do a publish of vm2 that includes this?

@patriksimek
Copy link
Owner

@michaeljacobdavis I have just added @orta into npm maintainers. I'm temporarily unavailable to maintain the project. Thank you!

@orta orta deleted the custom_files branch May 11, 2018 17:27
@orta
Copy link
Collaborator Author

orta commented May 11, 2018

Ace, thanks @patriksimek

@orta orta restored the custom_files branch May 11, 2018 17:27
@orta orta deleted the custom_files branch May 11, 2018 17:27
@orta
Copy link
Collaborator Author

orta commented May 11, 2018

Hah, sorry about all ^ 🍡

@orta orta restored the custom_files branch May 11, 2018 17:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants