fix(CodeModal): CodeEditor should fill height #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://chatbot-pr-chatbot-391.surge.sh A11y report: https://chatbot-pr-chatbot-391-a11y.surge.sh |
rebeccaalpert
force-pushed
the
code-modal-height-update
branch
from
5305a72 to
404738c
Compare
rebeccaalpert
force-pushed
the
code-modal-height-update
branch
from
404738c to
b37d324
Compare
rebeccaalpert
changed the title
rebeccaalpert
force-pushed
the
code-modal-height-update
branch
from
b37d324 to
a99aa89
Compare
rebeccaalpert
changed the title
rebeccaalpert
force-pushed
the
code-modal-height-update
branch
from
a99aa89 to
035bcf2
Compare
rebeccaalpert
force-pushed
the
code-modal-height-update
branch
from
035bcf2 to
72826fe
Compare
Upgrading PatternFly to pull in a bug fix for the CodeEditor - this lets it flow to full height in our modals.
rebeccaalpert
force-pushed
the
code-modal-height-update
branch
from
72826fe to
692b385
Compare
nicolethoen
approved these changes
Jan 7, 2025
|
🎉 This PR is included in version 2.2.0-prerelease.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading PatternFly to pull in a bug fix for the CodeEditor - this lets it flow to full height in our modals.
Also noticed that one of the attachments demos was broken due to the API change last quarter - fixing that here as well.