Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dependencies): Update versions to use PF6 #54

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

adamviktora
Copy link
Collaborator

@adamviktora adamviktora commented Aug 14, 2024

Closes #55

Few things / concerns:

  1. yarn lint:md was failing with the previous configuration in .eslintrc-md.json so I updated that to only run on js / jsx /ts / tsx blocks inside the markdown files. But I am not sure it works correctly + I don't know if the intention of running lint on .md files is to only check blocks of React code, or check the whole file.
  2. Current version of @patternfly/documentation-framework (6.0.0-alpha.77) is using old peer dependencies of @patternfly/patternfly, /react-core, /react-table and /react-code-editor. So versions of these packages are intentionally set to the ones specified in documentation-framework. We should update the versions of these packages again once beta is released.
  3. I updated the yarn.lock file based on a generated yarn.lock gotten from running the updated patternfly-extension-seed on a new repo (npx tmplr adamviktora/patternfly-extension-seed and then yarn install), I assume this is the way to do so - if not, let me know.

Copy link
Collaborator

@wise-king-sullyman wise-king-sullyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yarn lint:md was failing with the previous configuration in .eslintrc-md.json so I updated that to only run on js / jsx /ts / tsx blocks inside the markdown files. But I am not sure it works correctly + I don't know if the intention of running lint on .md files is to only check blocks of React code, or check the whole file.

It seems like this isn't catching any lint issues when I introduce them in the markdown....but it seems like it doesn't work properly now either so I won't block this PR over it.

Current version of @patternfly/documentation-framework (6.0.0-alpha.77) is using old peer dependencies of @patternfly/patternfly, /react-core, /react-table and /react-code-editor. So versions of these packages are intentionally set to the ones specified in documentation-framework. We should update the versions of these packages again once beta is released.

Makes sense, though I do think we should probably leave this issue open until we're either able to update to the beta versions or we reach a final decision about not having a beta version.

I updated the yarn.lock file based on a generated yarn.lock gotten from running the updated patternfly-extension-seed on a new repo (npx tmplr adamviktora/patternfly-extension-seed and then yarn install), I assume this is the way to do so - if not, let me know.

Yep that works! Though if you're working on this repo in the future we actually have a convenience script devSetup.sh which executes the seed in the seed repo with a set of predefined values for stuff like this.

@wise-king-sullyman
Copy link
Collaborator

I'm going to merge this PR but disconnect #53 so that it stays open for now.

@wise-king-sullyman wise-king-sullyman merged commit 282ea40 into patternfly:main Aug 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to latest PF6 versions compatible with the docs framework
2 participants