Fully built out v6 demo #209
Conversation
|
Noticed these issues below: On the same screen this utility classes don't change with dark theme Lastly, there is an inline style on the spans. I think this should be using |
nicolethoen
force-pushed
the
chore/202-dashboard
branch
from
4ea98f0
to
0e28819
Compare
Snyk has created this PR to upgrade @patternfly/react-core from 5.1.2 to 5.2.0. See this package in npm: https://www.npmjs.com/package/@patternfly/react-core See this project in Snyk: https://app.snyk.io/org/patternfly-bD6TiY6PxAoojbR6oZkeJN/project/015b745d-6900-4ccd-bbd4-e0cfeae5d2de?utm_source=github&utm_medium=referral&page=upgrade-pr
|
@andrew-ronaldson thanks for the feedback, connected with @mcoker (added as reviewer) for suggestions on fixes and fixed the overflowing grid item && update the incorrect text colors (note - now using bold tag rather than another color per suggestion). |
There was a problem hiding this comment.
I think it looks fine, but I left some comments. I think the summary is something like:
- Any existing utility classes will be based off of the old global vars. Spot checking, I think the "Text" utilities will be the most problematic. Flex, sizing, and accessibility utilities are probably fine the way they are and likely won't be any different in v6.
- Any
--pf-v5-global[...]vars will be from the old system and should ideally be replaced with--pf-t--global[...]. Looks like most of the v5 global vars reference in these files are for spacers, which is great, because the spacers are the same between v5 and v6, they just have a different--pf-t--globalprefix. - Looks like we're importing colors from react-tokens, and those are referencing our old v5 colors. But looks like they're used to set icon colors, which is covered in the next bullet.
- Any time we need to set a status color on an icon, we can use
<Icon status="..."> - Instead of
.pf-v5-u-font-color-200ortext.color_200(textis a reference to the text utility)....- The
<Text>component will give you small/grey text using thesmallvariant. - The
--pf-t--global--text--color--subtletoken will turn text grey/secondary in color (which you're already using some places, but not all) if you want the text to be grey but not small.
- The
|
Thanks @mcoker, just FYI I went back and made those updates based on your suggestions 👍 |
|
This just needs to be updated to the latest alphas as soon as the official alpha versions have been announced |
Fixed Patternfly brand name
V6 penta demo
Thanks for the updates. |
Fix: Clean up dependencies in main branch
Bumps [express](https://github.com/expressjs/express) from 4.18.0 to 4.19.2. - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/master/History.md) - [Commits](expressjs/express@4.18.0...4.19.2) --- updated-dependencies: - dependency-name: express dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…yarn/express-4.19.2 chore(deps): bump express from 4.18.0 to 4.19.2
fix: Remove storybook
|
That odd border still appears. Looks like it is from a |
|
Latest surge preview with alpha2 versions: https://pf6-alpha2-demo.surge.sh/ |
Towards #202
This PR adds the following items to the seed app for the V6 demo:
https://pf6-alpha2-demo.surge.sh/