fix(Text input): Added aria-expanded

patternfly · Oct 3, 2023 · 3914dc3 · 3914dc3
1 parent 7767e6a
commit 3914dc3
Show file tree

Hide file tree

Showing 15 changed files with 82 additions and 0 deletions.
diff --git a/...rc/components/ClipboardCopy/__tests__/Generated/__snapshots__/ClipboardCopy.test.tsx.snap b/...rc/components/ClipboardCopy/__tests__/Generated/__snapshots__/ClipboardCopy.test.tsx.snap
@@ -14,6 +14,7 @@ exports[`ClipboardCopy should match snapshot (auto-generated) 1`] = `
         class="pf-v5-c-form-control"
       >
         <input
+          aria-expanded="false"
           aria-invalid="false"
           aria-label="'Copyable input'"
           data-ouia-component-id="OUIA-Generated-TextInputBase-1"

diff --git a/...ges/react-core/src/components/DatePicker/__tests__/__snapshots__/DatePicker.test.tsx.snap b/...ges/react-core/src/components/DatePicker/__tests__/__snapshots__/DatePicker.test.tsx.snap
@@ -19,6 +19,7 @@ exports[`With popover opened 1`] = `
             class="pf-v5-c-form-control"
           >
             <input
+              aria-expanded="false"
               aria-invalid="false"
               aria-label="Date picker"
               data-ouia-component-id="OUIA-Generated-TextInputBase-4"
@@ -169,6 +170,7 @@ exports[`With popover opened 1`] = `
                       class="pf-v5-c-form-control"
                     >
                       <input
+                        aria-expanded="false"
                         aria-invalid="false"
                         aria-label="Select year"
                         data-ouia-component-id="OUIA-Generated-TextInputBase-5"
@@ -793,6 +795,7 @@ exports[`disabled date picker 1`] = `
             class="pf-v5-c-form-control pf-m-disabled"
           >
             <input
+              aria-expanded="false"
               aria-invalid="false"
               aria-label="disabled date picker"
               data-ouia-component-id="OUIA-Generated-TextInputBase-1"

diff --git a/...ges/react-core/src/components/FileUpload/__tests__/__snapshots__/FileUpload.test.tsx.snap b/...ges/react-core/src/components/FileUpload/__tests__/__snapshots__/FileUpload.test.tsx.snap
@@ -20,6 +20,7 @@ exports[`simple fileupload 1`] = `
           >
             <input
               aria-describedby="simple-text-file-browse-button"
+              aria-expanded="false"
               aria-invalid="false"
               aria-label="Drag a file here or browse to upload"
               data-ouia-component-id="OUIA-Generated-TextInputBase-1"

diff --git a/...eact-core/src/components/FileUpload/__tests__/__snapshots__/FileUploadField.test.tsx.snap b/...eact-core/src/components/FileUpload/__tests__/__snapshots__/FileUploadField.test.tsx.snap
@@ -19,6 +19,7 @@ exports[`simple fileuploadfield 1`] = `
           >
             <input
               aria-describedby="custom-file-upload-browse-button"
+              aria-expanded="false"
               aria-invalid="false"
               aria-label="Do something custom with this!"
               data-ouia-component-id="OUIA-Generated-TextInputBase-1"

diff --git a/packages/react-core/src/components/LoginPage/__tests__/__snapshots__/LoginForm.test.tsx.snap b/packages/react-core/src/components/LoginPage/__tests__/__snapshots__/LoginForm.test.tsx.snap
@@ -37,6 +37,7 @@ exports[`LoginForm LoginForm with rememberMeLabel 1`] = `
           class="pf-v5-c-form-control"
         >
           <input
+            aria-expanded="false"
             aria-invalid="false"
             data-ouia-component-id="OUIA-Generated-TextInputBase-9"
             data-ouia-component-type="PF5/TextInput"
@@ -81,6 +82,7 @@ exports[`LoginForm LoginForm with rememberMeLabel 1`] = `
           class="pf-v5-c-form-control"
         >
           <input
+            aria-expanded="false"
             aria-invalid="false"
             data-ouia-component-id="OUIA-Generated-TextInputBase-10"
             data-ouia-component-type="PF5/TextInput"
@@ -184,6 +186,7 @@ exports[`LoginForm LoginForm with show password 1`] = `
           class="pf-v5-c-form-control"
         >
           <input
+            aria-expanded="false"
             aria-invalid="false"
             data-ouia-component-id="OUIA-Generated-TextInputBase-11"
             data-ouia-component-type="PF5/TextInput"
@@ -234,6 +237,7 @@ exports[`LoginForm LoginForm with show password 1`] = `
               class="pf-v5-c-form-control"
             >
               <input
+                aria-expanded="false"
                 aria-invalid="false"
                 data-ouia-component-id="OUIA-Generated-TextInputBase-12"
                 data-ouia-component-type="PF5/TextInput"
@@ -339,6 +343,7 @@ exports[`LoginForm should render Login form 1`] = `
           class="pf-v5-c-form-control"
         >
           <input
+            aria-expanded="false"
             aria-invalid="false"
             data-ouia-component-id="OUIA-Generated-TextInputBase-1"
             data-ouia-component-type="PF5/TextInput"
@@ -383,6 +388,7 @@ exports[`LoginForm should render Login form 1`] = `
           class="pf-v5-c-form-control"
         >
           <input
+            aria-expanded="false"
             aria-invalid="false"
             data-ouia-component-id="OUIA-Generated-TextInputBase-2"
             data-ouia-component-type="PF5/TextInput"

diff --git a/...s/react-core/src/components/NumberInput/__tests__/__snapshots__/NumberInput.test.tsx.snap b/...s/react-core/src/components/NumberInput/__tests__/__snapshots__/NumberInput.test.tsx.snap
@@ -47,6 +47,7 @@ exports[`numberInput disables lower threshold 1`] = `
           class="pf-v5-c-form-control pf-m-readonly"
         >
           <input
+            aria-expanded="false"
             aria-invalid="false"
             aria-label="Input"
             data-ouia-component-id="OUIA-Generated-TextInputBase-7"
@@ -140,6 +141,7 @@ exports[`numberInput disables upper threshold 1`] = `
           class="pf-v5-c-form-control pf-m-readonly"
         >
           <input
+            aria-expanded="false"
             aria-invalid="false"
             aria-label="Input"
             data-ouia-component-id="OUIA-Generated-TextInputBase-8"
@@ -235,6 +237,7 @@ exports[`numberInput passes button props successfully 1`] = `
           class="pf-v5-c-form-control pf-m-readonly"
         >
           <input
+            aria-expanded="false"
             aria-invalid="false"
             aria-label="Input"
             data-ouia-component-id="OUIA-Generated-TextInputBase-13"
@@ -329,6 +332,7 @@ exports[`numberInput passes input props successfully 1`] = `
           class="pf-v5-c-form-control"
         >
           <input
+            aria-expanded="false"
             aria-invalid="false"
             aria-label="Input"
             data-ouia-component-id="OUIA-Generated-TextInputBase-12"
@@ -423,6 +427,7 @@ exports[`numberInput renders custom width 1`] = `
           class="pf-v5-c-form-control pf-m-readonly"
         >
           <input
+            aria-expanded="false"
             aria-invalid="false"
             aria-label="Input"
             data-ouia-component-id="OUIA-Generated-TextInputBase-11"
@@ -517,6 +522,7 @@ exports[`numberInput renders defaults & extra props 1`] = `
           class="pf-v5-c-form-control pf-m-readonly"
         >
           <input
+            aria-expanded="false"
             aria-invalid="false"
             aria-label="Input"
             data-ouia-component-id="OUIA-Generated-TextInputBase-1"
@@ -611,6 +617,7 @@ exports[`numberInput renders disabled 1`] = `
           class="pf-v5-c-form-control pf-m-readonly pf-m-disabled"
         >
           <input
+            aria-expanded="false"
             aria-invalid="false"
             aria-label="Input"
             data-ouia-component-id="OUIA-Generated-TextInputBase-6"
@@ -706,6 +713,7 @@ exports[`numberInput renders error validated 1`] = `
           class="pf-v5-c-form-control pf-m-readonly pf-m-error"
         >
           <input
+            aria-expanded="false"
             aria-invalid="true"
             aria-label="Input"
             data-ouia-component-id="OUIA-Generated-TextInputBase-3"
@@ -820,6 +828,7 @@ exports[`numberInput renders success validated 1`] = `
           class="pf-v5-c-form-control pf-m-readonly pf-m-success"
         >
           <input
+            aria-expanded="false"
             aria-invalid="false"
             aria-label="Input"
             data-ouia-component-id="OUIA-Generated-TextInputBase-2"
@@ -939,6 +948,7 @@ exports[`numberInput renders unit & position 1`] = `
           class="pf-v5-c-form-control pf-m-readonly"
         >
           <input
+            aria-expanded="false"
             aria-invalid="false"
             aria-label="Input"
             data-ouia-component-id="OUIA-Generated-TextInputBase-10"
@@ -1032,6 +1042,7 @@ exports[`numberInput renders unit 1`] = `
           class="pf-v5-c-form-control pf-m-readonly"
         >
           <input
+            aria-expanded="false"
             aria-invalid="false"
             aria-label="Input"
             data-ouia-component-id="OUIA-Generated-TextInputBase-9"
@@ -1130,6 +1141,7 @@ exports[`numberInput renders value 1`] = `
           class="pf-v5-c-form-control pf-m-readonly"
         >
           <input
+            aria-expanded="false"
             aria-invalid="false"
             aria-label="Input"
             data-ouia-component-id="OUIA-Generated-TextInputBase-5"
@@ -1223,6 +1235,7 @@ exports[`numberInput renders warning validated 1`] = `
           class="pf-v5-c-form-control pf-m-readonly pf-m-warning"
         >
           <input
+            aria-expanded="false"
             aria-invalid="false"
             aria-label="Input"
             data-ouia-component-id="OUIA-Generated-TextInputBase-4"

diff --git a/...core/src/components/Pagination/__tests__/Generated/__snapshots__/Navigation.test.tsx.snap b/...core/src/components/Pagination/__tests__/Generated/__snapshots__/Navigation.test.tsx.snap
@@ -75,6 +75,7 @@ exports[`Navigation should match snapshot (auto-generated) 1`] = `
         class="pf-v5-c-form-control"
       >
         <input
+          aria-expanded="false"
           aria-invalid="false"
           aria-label="Current page"
           data-ouia-component-id="OUIA-Generated-TextInputBase-1"

diff --git a/...ges/react-core/src/components/Pagination/__tests__/__snapshots__/Pagination.test.tsx.snap b/...ges/react-core/src/components/Pagination/__tests__/__snapshots__/Pagination.test.tsx.snap
@@ -134,6 +134,7 @@ exports[`Pagination API verify inset2xl inset breakpoints 1`] = `
           class="pf-v5-c-form-control"
         >
           <input
+            aria-expanded="false"
             aria-invalid="false"
             aria-label="Current page"
             data-ouia-component-id="OUIA-Generated-TextInputBase-45"
@@ -342,6 +343,7 @@ exports[`Pagination API verify insetLg inset breakpoints 1`] = `
           class="pf-v5-c-form-control"
         >
           <input
+            aria-expanded="false"
             aria-invalid="false"
             aria-label="Current page"
             data-ouia-component-id="OUIA-Generated-TextInputBase-43"
@@ -550,6 +552,7 @@ exports[`Pagination API verify insetMd inset breakpoints 1`] = `
           class="pf-v5-c-form-control"
         >
           <input
+            aria-expanded="false"
             aria-invalid="false"
             aria-label="Current page"
             data-ouia-component-id="OUIA-Generated-TextInputBase-42"
@@ -758,6 +761,7 @@ exports[`Pagination API verify insetNone inset breakpoints 1`] = `
           class="pf-v5-c-form-control"
         >
           <input
+            aria-expanded="false"
             aria-invalid="false"
             aria-label="Current page"
             data-ouia-component-id="OUIA-Generated-TextInputBase-40"
@@ -966,6 +970,7 @@ exports[`Pagination API verify insetSm inset breakpoints 1`] = `
           class="pf-v5-c-form-control"
         >
           <input
+            aria-expanded="false"
             aria-invalid="false"
             aria-label="Current page"
             data-ouia-component-id="OUIA-Generated-TextInputBase-41"
@@ -1174,6 +1179,7 @@ exports[`Pagination API verify insetXl inset breakpoints 1`] = `
           class="pf-v5-c-form-control"
         >
           <input
+            aria-expanded="false"
             aria-invalid="false"
             aria-label="Current page"
             data-ouia-component-id="OUIA-Generated-TextInputBase-44"
@@ -1368,6 +1374,7 @@ exports[`Pagination component render custom pagination toggle 1`] = `
           class="pf-v5-c-form-control"
         >
           <input
+            aria-expanded="false"
             aria-invalid="false"
             aria-label="Current page"
             data-ouia-component-id="OUIA-Generated-TextInputBase-13"
@@ -1580,6 +1587,7 @@ exports[`Pagination component render custom perPageOptions 1`] = `
           class="pf-v5-c-form-control"
         >
           <input
+            aria-expanded="false"
             aria-invalid="false"
             aria-label="Current page"
             data-ouia-component-id="OUIA-Generated-TextInputBase-9"
@@ -1790,6 +1798,7 @@ exports[`Pagination component render custom start end 1`] = `
           class="pf-v5-c-form-control"
         >
           <input
+            aria-expanded="false"
             aria-invalid="false"
             aria-label="Current page"
             data-ouia-component-id="OUIA-Generated-TextInputBase-11"
@@ -1959,6 +1968,7 @@ exports[`Pagination component render empty per page options 1`] = `
           class="pf-v5-c-form-control"
         >
           <input
+            aria-expanded="false"
             aria-invalid="false"
             aria-label="Current page"
             data-ouia-component-id="OUIA-Generated-TextInputBase-10"
@@ -2169,6 +2179,7 @@ exports[`Pagination component render last page 1`] = `
           class="pf-v5-c-form-control"
         >
           <input
+            aria-expanded="false"
             aria-invalid="false"
             aria-label="Current page"
             data-ouia-component-id="OUIA-Generated-TextInputBase-8"
@@ -2383,6 +2394,7 @@ exports[`Pagination component render limited number of pages 1`] = `
           class="pf-v5-c-form-control pf-m-disabled"
         >
           <input
+            aria-expanded="false"
             aria-invalid="false"
             aria-label="Current page"
             data-ouia-component-id="OUIA-Generated-TextInputBase-6"
@@ -2586,6 +2598,7 @@ exports[`Pagination component render should render correctly bottom 1`] = `
           class="pf-v5-c-form-control"
         >
           <input
+            aria-expanded="false"
             aria-invalid="false"
             aria-label="Current page"
             data-ouia-component-id="OUIA-Generated-TextInputBase-2"
@@ -2786,6 +2799,7 @@ exports[`Pagination component render should render correctly bottom sticky 1`] =
           class="pf-v5-c-form-control"
         >
           <input
+            aria-expanded="false"
             aria-invalid="false"
             aria-label="Current page"
             data-ouia-component-id="OUIA-Generated-TextInputBase-4"
@@ -3130,6 +3144,7 @@ exports[`Pagination component render should render correctly disabled 1`] = `
           class="pf-v5-c-form-control pf-m-disabled"
         >
           <input
+            aria-expanded="false"
             aria-invalid="false"
             aria-label="Current page"
             data-ouia-component-id="OUIA-Generated-TextInputBase-5"
@@ -3345,6 +3360,7 @@ exports[`Pagination component render should render correctly sticky 1`] = `
           class="pf-v5-c-form-control"
         >
           <input
+            aria-expanded="false"
             aria-invalid="false"
             aria-label="Current page"
             data-ouia-component-id="OUIA-Generated-TextInputBase-3"
@@ -3557,6 +3573,7 @@ exports[`Pagination component render should render correctly top 1`] = `
           class="pf-v5-c-form-control"
         >
           <input
+            aria-expanded="false"
             aria-invalid="false"
             aria-label="Current page"
             data-ouia-component-id="OUIA-Generated-TextInputBase-1"
@@ -3769,6 +3786,7 @@ exports[`Pagination component render titles 1`] = `
           class="pf-v5-c-form-control"
         >
           <input
+            aria-expanded="false"
             aria-invalid="false"
             aria-label="Current page"
             data-ouia-component-id="OUIA-Generated-TextInputBase-12"
@@ -3981,6 +3999,7 @@ exports[`Pagination component render up drop direction 1`] = `
           class="pf-v5-c-form-control"
         >
           <input
+            aria-expanded="false"
             aria-invalid="false"
             aria-label="Current page"
             data-ouia-component-id="OUIA-Generated-TextInputBase-14"
@@ -4193,6 +4212,7 @@ exports[`Pagination component render zero results 1`] = `
           class="pf-v5-c-form-control pf-m-disabled"
         >
           <input
+            aria-expanded="false"
             aria-invalid="false"
             aria-label="Current page"
             data-ouia-component-id="OUIA-Generated-TextInputBase-7"

diff --git a/...s/react-core/src/components/SearchInput/__tests__/__snapshots__/SearchInput.test.tsx.snap b/...s/react-core/src/components/SearchInput/__tests__/__snapshots__/SearchInput.test.tsx.snap
@@ -333,6 +333,7 @@ exports[`SearchInput advanced search with custom attributes 1`] = `
                     class="pf-v5-c-form-control"
                   >
                     <input
+                      aria-expanded="false"
                       aria-invalid="false"
                       data-ouia-component-id="OUIA-Generated-TextInputBase-1"
                       data-ouia-component-type="PF5/TextInput"
@@ -369,6 +370,7 @@ exports[`SearchInput advanced search with custom attributes 1`] = `
                     class="pf-v5-c-form-control"
                   >
                     <input
+                      aria-expanded="false"
                       aria-invalid="false"
                       data-ouia-component-id="OUIA-Generated-TextInputBase-2"
                       data-ouia-component-type="PF5/TextInput"
@@ -405,6 +407,7 @@ exports[`SearchInput advanced search with custom attributes 1`] = `
                     class="pf-v5-c-form-control"
                   >
                     <input
+                      aria-expanded="false"
                       aria-invalid="false"
                       data-ouia-component-id="OUIA-Generated-TextInputBase-3"
                       data-ouia-component-type="PF5/TextInput"