allow no onSelect, update integration and snap

patternfly · Feb 2, 2023 · 6d2bee8 · 6d2bee8
1 parent a4d0665
commit 6d2bee8
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 6 deletions.
diff --git a/packages/react-core/src/next/components/Dropdown/Dropdown.tsx b/packages/react-core/src/next/components/Dropdown/Dropdown.tsx
@@ -104,7 +104,7 @@ const DropdownBase: React.FunctionComponent<DropdownProps> = ({
     <Menu
       className={css(className)}
       ref={menuRef}
-      onSelect={(event, itemId) => onSelect(event, itemId)}
+      onSelect={(event, itemId) => onSelect && onSelect(event, itemId)}
       isPlain={isPlain}
       isScrollable={isScrollable}
       {...(minWidth && {

diff --git a/packages/react-core/src/next/components/Select/Select.tsx b/packages/react-core/src/next/components/Select/Select.tsx
@@ -94,7 +94,7 @@ const SelectBase: React.FunctionComponent<SelectProps & OUIAProps> = ({
     <Menu
       className={css(className)}
       ref={menuRef}
-      onSelect={(event, itemId) => onSelect(event, itemId)}
+      onSelect={(event, itemId) => onSelect && onSelect(event, itemId)}
       isPlain={isPlain}
       selected={selected}
       {...(minWidth && {

diff --git a/packages/react-integration/cypress/integration/tablesimpleactions.spec.ts b/packages/react-integration/cypress/integration/tablesimpleactions.spec.ts
@@ -20,14 +20,14 @@ describe('Table Simple Actions Test', () => {
   });
 
   it('Verify dropdown toggle', () => {
-    cy.get('td .pf-c-dropdown__toggle')
+    cy.get('td .pf-c-menu-toggle')
       .first()
       .should('exist');
-    cy.get('td .pf-c-dropdown__toggle')
+    cy.get('td .pf-c-menu-toggle')
       .first()
       .click();
-    cy.get('.pf-c-dropdown__menu').should('exist');
-    cy.get('.pf-c-dropdown__menu-item')
+    cy.get('.pf-c-menu').should('exist');
+    cy.get('.pf-c-menu__item')
       .first()
       .click();
   });

diff --git a/packages/react-table/src/components/Table/__tests__/__snapshots__/Table.test.tsx.snap b/packages/react-table/src/components/Table/__tests__/__snapshots__/Table.test.tsx.snap
@@ -157,6 +157,7 @@ exports[`Table Actions table 1`] = `
             >
               <button
                 aria-expanded="false"
+                aria-label="Kebab toggle"
                 class="pf-c-menu-toggle pf-m-plain"
                 type="button"
               >
@@ -234,6 +235,7 @@ exports[`Table Actions table 1`] = `
             >
               <button
                 aria-expanded="false"
+                aria-label="Kebab toggle"
                 class="pf-c-menu-toggle pf-m-plain"
                 type="button"
               >
@@ -311,6 +313,7 @@ exports[`Table Actions table 1`] = `
             >
               <button
                 aria-expanded="false"
+                aria-label="Kebab toggle"
                 class="pf-c-menu-toggle pf-m-plain"
                 type="button"
               >
@@ -388,6 +391,7 @@ exports[`Table Actions table 1`] = `
             >
               <button
                 aria-expanded="false"
+                aria-label="Kebab toggle"
                 class="pf-c-menu-toggle pf-m-plain"
                 type="button"
               >
@@ -465,6 +469,7 @@ exports[`Table Actions table 1`] = `
             >
               <button
                 aria-expanded="false"
+                aria-label="Kebab toggle"
                 class="pf-c-menu-toggle pf-m-plain"
                 type="button"
               >
@@ -542,6 +547,7 @@ exports[`Table Actions table 1`] = `
             >
               <button
                 aria-expanded="false"
+                aria-label="Kebab toggle"
                 class="pf-c-menu-toggle pf-m-plain"
                 type="button"
               >
@@ -619,6 +625,7 @@ exports[`Table Actions table 1`] = `
             >
               <button
                 aria-expanded="false"
+                aria-label="Kebab toggle"
                 class="pf-c-menu-toggle pf-m-plain"
                 type="button"
               >
@@ -696,6 +703,7 @@ exports[`Table Actions table 1`] = `
             >
               <button
                 aria-expanded="false"
+                aria-label="Kebab toggle"
                 class="pf-c-menu-toggle pf-m-plain"
                 type="button"
               >
@@ -773,6 +781,7 @@ exports[`Table Actions table 1`] = `
             >
               <button
                 aria-expanded="false"
+                aria-label="Kebab toggle"
                 class="pf-c-menu-toggle pf-m-plain"
                 type="button"
               >
@@ -5383,6 +5392,7 @@ exports[`Table Simple Actions table 1`] = `
             >
               <button
                 aria-expanded="false"
+                aria-label="Kebab toggle"
                 class="pf-c-menu-toggle pf-m-plain"
                 type="button"
               >
@@ -5460,6 +5470,7 @@ exports[`Table Simple Actions table 1`] = `
             >
               <button
                 aria-expanded="false"
+                aria-label="Kebab toggle"
                 class="pf-c-menu-toggle pf-m-plain"
                 type="button"
               >
@@ -5537,6 +5548,7 @@ exports[`Table Simple Actions table 1`] = `
             >
               <button
                 aria-expanded="false"
+                aria-label="Kebab toggle"
                 class="pf-c-menu-toggle pf-m-plain"
                 type="button"
               >
@@ -5614,6 +5626,7 @@ exports[`Table Simple Actions table 1`] = `
             >
               <button
                 aria-expanded="false"
+                aria-label="Kebab toggle"
                 class="pf-c-menu-toggle pf-m-plain"
                 type="button"
               >
@@ -5691,6 +5704,7 @@ exports[`Table Simple Actions table 1`] = `
             >
               <button
                 aria-expanded="false"
+                aria-label="Kebab toggle"
                 class="pf-c-menu-toggle pf-m-plain"
                 type="button"
               >
@@ -5768,6 +5782,7 @@ exports[`Table Simple Actions table 1`] = `
             >
               <button
                 aria-expanded="false"
+                aria-label="Kebab toggle"
                 class="pf-c-menu-toggle pf-m-plain"
                 type="button"
               >
@@ -5845,6 +5860,7 @@ exports[`Table Simple Actions table 1`] = `
             >
               <button
                 aria-expanded="false"
+                aria-label="Kebab toggle"
                 class="pf-c-menu-toggle pf-m-plain"
                 type="button"
               >
@@ -5922,6 +5938,7 @@ exports[`Table Simple Actions table 1`] = `
             >
               <button
                 aria-expanded="false"
+                aria-label="Kebab toggle"
                 class="pf-c-menu-toggle pf-m-plain"
                 type="button"
               >
@@ -5999,6 +6016,7 @@ exports[`Table Simple Actions table 1`] = `
             >
               <button
                 aria-expanded="false"
+                aria-label="Kebab toggle"
                 class="pf-c-menu-toggle pf-m-plain"
                 type="button"
               >
@@ -6076,6 +6094,7 @@ exports[`Table Simple Actions table 1`] = `
             >
               <button
                 aria-expanded="false"
+                aria-label="Kebab toggle"
                 class="pf-c-menu-toggle pf-m-plain pf-m-disabled"
                 disabled=""
                 type="button"