Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TableComposable - dynamically built actions menus should not use deprecated dropdown #8489

Closed
nicolethoen opened this issue Jan 5, 2023 · 0 comments · Fixed by #8629
Closed

TableComposable - dynamically built actions menus should not use deprecated dropdown #8489

nicolethoen opened this issue Jan 5, 2023 · 0 comments · Fixed by #8629
Assignees
@kmcfaul
Labels
Breaking change 💥 this change requires a major release and has API changes. PF5
Milestone
2023.04

Comments

@nicolethoen
Copy link
Contributor

A more robust solution to #8475

The generated actions menu in an ActionCell should build a Dropdown next component rather than a deprecated Dropdown component, and the menu on the Dropdown component should allow for passing a menuAppendTo prop.
@nicolethoen nicolethoen added Breaking change 💥 this change requires a major release and has API changes. bug PF5 labels Jan 5, 2023
@github-project-automation github-project-automation bot moved this to Not started in PatternFly Issues Jan 5, 2023
@nicolethoen nicolethoen added this to the 2023.04 milestone Jan 6, 2023
@kmcfaul kmcfaul self-assigned this Jan 25, 2023
@nicolethoen nicolethoen moved this from Not started to In Progress in PatternFly Issues Jan 26, 2023
@nicolethoen nicolethoen moved this from In Progress to PR Review in PatternFly Issues Feb 6, 2023
@kmcfaul kmcfaul linked a pull request Feb 9, 2023 that will close this issue
feat(Table): update ActionsColumn to use Dropdown next #8629
Merged
@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kmcfaul kmcfaul

Labels
Breaking change 💥 this change requires a major release and has API changes. PF5
Projects
PatternFly Issues
Archived in project
Milestone
2023.04
Development

Successfully merging a pull request may close this issue.

feat(Table): update ActionsColumn to use Dropdown next kmcfaul/patternfly-react
2 participants
@nicolethoen @kmcfaul