-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Table): update ActionsColumn to use Dropdown next #8629
Conversation
Preview: https://patternfly-react-pr-8629.surge.sh A11y report: https://patternfly-react-pr-8629-a11y.surge.sh |
12773ca
to
6d2bee8
Compare
Thanks to @jeffpuzzo for helping me debug the handful of build errors that were happening due to next component usage. For next components at least in Table, the full path of Also updated Select and Dropdown next to prevent the component from throwing an error when the optional |
6d2bee8
to
e4ed53e
Compare
Rebased. I removed the rebase add of |
@jeffpuzzo Pinging you for a review especially of the Wizard components after the rebase, there were several merge conflicts and want to make sure I didn't miss something. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-reviewed wizard related changes. LGTM
Your changes have been released in:
Thanks for your contribution! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
What: Closes #8390
ActionsColumn
to use Dropdown-next componentspopperProps
to Dropdown-next to allow customization of Popper (includingdirection
,position
,popperMatchesTriggerWidth
that is used byActionsColumn
). If this would be better as separately piped props let me know and I can update them. But for now this will allow the greatest flexibility.MenuToggle
for custom toggle