Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Table): update ActionsColumn to use Dropdown next #8629

Merged
merged 8 commits into from
Feb 10, 2023

Conversation

kmcfaul
Copy link
Contributor

@kmcfaul kmcfaul commented Jan 30, 2023

What: Closes #8390

  • Updates ActionsColumn to use Dropdown-next components
  • Adds popperProps to Dropdown-next to allow customization of Popper (including direction, position, popperMatchesTriggerWidth that is used by ActionsColumn). If this would be better as separately piped props let me know and I can update them. But for now this will allow the greatest flexibility.
  • Updates examples to use MenuToggle for custom toggle

@patternfly-build
Copy link
Contributor

patternfly-build commented Jan 31, 2023

@kmcfaul kmcfaul force-pushed the table-actions-next branch 6 times, most recently from 12773ca to 6d2bee8 Compare February 2, 2023 16:21
@kmcfaul
Copy link
Contributor Author

kmcfaul commented Feb 2, 2023

Thanks to @jeffpuzzo for helping me debug the handful of build errors that were happening due to next component usage. For next components at least in Table, the full path of @patternfly/react-core/dist/esm/next/components has to be included for the GH build to work (while @patternfly/react-core/next works locally).

Also updated Select and Dropdown next to prevent the component from throwing an error when the optional onSelect prop wasn't passed.

@kmcfaul kmcfaul force-pushed the table-actions-next branch from 6d2bee8 to e4ed53e Compare February 9, 2023 15:20
@kmcfaul
Copy link
Contributor Author

kmcfaul commented Feb 9, 2023

Rebased. I removed the rebase add of menuAppendTo to ActionColumn as that was an add for the old Dropdown. The next Dropdown defaults to inline and doesn't currently expose the appendTo prop.

@kmcfaul kmcfaul requested a review from jpuzz0 February 9, 2023 15:51
@kmcfaul
Copy link
Contributor Author

kmcfaul commented Feb 9, 2023

@jeffpuzzo Pinging you for a review especially of the Wizard components after the rebase, there were several merge conflicts and want to make sure I didn't miss something.

Copy link
Contributor

@jpuzz0 jpuzz0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewed wizard related changes. LGTM

@nicolethoen nicolethoen merged commit 43601af into patternfly:v5 Feb 10, 2023
@patternfly-build
Copy link
Contributor

Your changes have been released in:

  • eslint-plugin-patternfly-react@4.80.5-alpha.0
  • @patternfly/react-code-editor@5.0.0-alpha.10
  • @patternfly/react-core@5.0.0-alpha.10
  • @patternfly/react-docs@6.0.0-alpha.11
  • @patternfly/react-table@5.0.0-alpha.10

Thanks for your contribution! 🎉

Copy link
Contributor

@mattnolting mattnolting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants