-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(page): support for context selector in sidebar #10686
Conversation
Preview: https://patternfly-react-pr-10686.surge.sh A11y report: https://patternfly-react-pr-10686-a11y.surge.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perfecto!
@kmcfaul I pushed a couple of updates to |
Your changes have been released in:
Thanks for your contribution! 🎉 |
What: Closes #10681
Adds support for
isContextSelector
to<PageSidebarBody>
, adds a demo just to show toggle/menu placement.Updates jump links toggle and tabs toggle from the button updates in core that wrap button text and icons in their own wrappers:
<Button icon=[...]>
propConvenience links:
Things to follow up on before merging or as a follow up after it's merged:
<Dropdown>
in the demo to a<Select>
, or whatever is most appropriate.