Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(page): support for context selector in sidebar #10686

Merged
merged 7 commits into from
Jul 3, 2024

Conversation

mcoker
Copy link
Contributor

@mcoker mcoker commented Jul 1, 2024

What: Closes #10681

Adds support for isContextSelector to <PageSidebarBody>, adds a demo just to show toggle/menu placement.

Updates jump links toggle and tabs toggle from the button updates in core that wrap button text and icons in their own wrappers:

  • Removes the wrappers for toggle text
  • Moves the toggle icons into the <Button icon=[...]> prop

Convenience links:

Things to follow up on before merging or as a follow up after it's merged:

  • Should we keep the demo I added? Just not sure if it's necessary beyond verifying the feature. If we keep it...
  • Change the <Dropdown> in the demo to a <Select>, or whatever is most appropriate.
  • Possibly wire up something in the page to show the difference between admin/developer mode, or whatever this menu is typically designed to do.

@patternfly-build
Copy link
Contributor

patternfly-build commented Jul 1, 2024

Copy link
Collaborator

@andrew-ronaldson andrew-ronaldson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfecto!

@mcoker
Copy link
Contributor Author

mcoker commented Jul 3, 2024

@kmcfaul I pushed a couple of updates to <Button>s in jump links and tabs (in this commit) if you want to have a look. We were passing an icon and text as children, and I think the icon should be in the icon wrapper (I'm thinking it should have been that way in v5, too). Not sure if it might be useful to look over our buttons again and see if there are any others like that we need to update?

@nicolethoen nicolethoen linked an issue Jul 3, 2024 that may be closed by this pull request
@mcoker mcoker mentioned this pull request Jul 3, 2024
@mcoker mcoker marked this pull request as ready for review July 3, 2024 20:35
@tlabaj tlabaj merged commit b85fb19 into patternfly:v6 Jul 3, 2024
13 checks passed
@patternfly-build
Copy link
Contributor

Your changes have been released in:

  • @patternfly/react-charts@8.0.0-alpha.31
  • @patternfly/react-code-editor@6.0.0-alpha.78
  • @patternfly/react-core@6.0.0-alpha.78
  • @patternfly/react-docs@7.0.0-alpha.84
  • @patternfly/react-drag-drop@6.0.0-alpha.60
  • @patternfly/react-icons@6.0.0-alpha.29
  • demo-app-ts@5.1.1-alpha.77
  • @patternfly/react-styles@6.0.0-alpha.28
  • @patternfly/react-table@6.0.0-alpha.79
  • @patternfly/react-templates@6.0.0-alpha.28
  • @patternfly/react-tokens@6.0.0-alpha.28

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Page sidebar - support for context selector/perspective switcher
5 participants