-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Popover): updated appendTo to inline by default #8621
fix(Popover): updated appendTo to inline by default #8621
Conversation
Preview: https://patternfly-react-pr-8621.surge.sh A11y report: https://patternfly-react-pr-8621-a11y.surge.sh |
1ae1055
to
f443fd7
Compare
f443fd7
to
4c993df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thatblindgeye does this need some sort of codemod/warning that there is now an extra div if appendTo was not explicitly set?
Oh, and suddenly another thought. What if people want to put a popover on something that is inline, like a button within a span? then they cannot append inline since it would result in a div being placed in a span. I wonder if the wrapping component should also be something that the user can configure to ensure valid HTML?
@nicolethoen I can add that in to the codemod PR I currently have up! Regarding configuring the wrapper component, that might require further updating elements of the Popover since Popover uses In terms of that extraneous |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small miss
839d574
to
6b31199
Compare
6b31199
to
e6222bc
Compare
What: Closes #8599
Popover examples
This results in markup similar to Timepicker (wrapping the Popper in a div internally and appending to that wrapper div).
Additional issues: