chore(CI): updated node version used for gh actions #8766
Conversation
|
Preview: https://patternfly-react-pr-8766.surge.sh A11y report: https://patternfly-react-pr-8766-a11y.surge.sh |
|
Adding do not merge as I think I might have found an issue when doing a test merge of this in my fork |
|
Should be good to merge now that I've pulled in the changes I made in the latest docs-framework alpha and enabled that new behavior using the legacySSL flag. |
|
The docs build failure that's showing is because the actions are currently still running as node v14. We can either merge it with the failing check, or I can remove the legacySSL flag from this PR and add it back in a followup PR. Going that route will mean that this PR will fail to build when it's merged though. |
|
I think this should be good to merge now, but just in case it starts causing gh actions related issues we may want to make it the last thing we merge before we go into code freeze. |
|
Looks like the build is complaining about openssl |
|
@nicolethoen yeah it will complain since that option wasn't added until node v17. Once it gets merged and the GH actions actually start running using node 18 it won't complain, and if we don't have that flag the build will fail with 18. I can remove the flag for now and add it back in a followup if we want to go that way. It will just mean that the release CI will definitely fail once it merges. |
|
I get it. I think it's fine. I think we can merge this on Monday and if anything extra pops up from this, I can dig into it while people are catching up on code mods |
This reverts commit 401cc8c.
This reverts commit 401cc8c.
What: Closes #8303
Additional issues: