Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(TextInput): Add Focus TextInput example #912

Closed
wants to merge 1 commit into from
Closed

feat(TextInput): Add Focus TextInput example #912

wants to merge 1 commit into from

Conversation

boaz0
Copy link
Member

@boaz0 boaz0 commented Nov 13, 2018

I added an example of how to focus on TextInput.

Using innerRef props that was added in this change and React.forwardRef I could get the input component and focus on it.

@coveralls
Copy link

coveralls commented Nov 13, 2018

Pull Request Test Coverage Report for Build 3410

  • 3 of 4 (75.0%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.05%) to 82.049%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/patternfly-4/react-core/src/components/TextInput/TextInput.js 3 4 75.0%
Files with Coverage Reduction New Missed Lines %
packages/patternfly-4/react-core/src/components/TextInput/TextInput.js 3 75.0%
Totals Coverage Status
Change from base Build 3402: -0.05%
Covered Lines: 3952
Relevant Lines: 4554

💛 - Coveralls

@patternfly-build
Copy link
Contributor

PatternFly-React preview: https://912-pr-patternfly-react-patternfly.surge.sh

@tlabaj
Copy link
Contributor

tlabaj commented Nov 28, 2018

@boaz1337 Can you please resolve conflicts in your branch.

@jgiardino
Copy link
Collaborator

I'm not able to review this. I get a "page not found" error when I try to navigate to the preview.

@boaz0
Copy link
Member Author

boaz0 commented Dec 4, 2018

@jgiardino yes me too. I guess because tests failed.

I will try to fix this soon as possible.

Thanks.

@tlabaj
Copy link
Contributor

tlabaj commented Dec 13, 2018

@boaz1337 looks like this one is still failing the build. Could you please take a look at that. Thanks!

@dgutride
Copy link
Member

dgutride commented Mar 11, 2019

This PR has become stale - it isn't related to any issues we have open. If you'd like to continue forward, please respond before March 18, 2019 and we'll keep it open otherwise we'll close as inactive.

@dgutride dgutride self-assigned this Mar 11, 2019
Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>
@codecov-io
Copy link

Codecov Report

Merging #912 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #912      +/-   ##
==========================================
+ Coverage   83.86%   83.87%   +<.01%     
==========================================
  Files         556      557       +1     
  Lines        5857     5859       +2     
  Branches       12       12              
==========================================
+ Hits         4912     4914       +2     
  Misses        943      943              
  Partials        2        2
Flag Coverage Δ
#patternfly3 84.89% <ø> (ø) ⬆️
#patternfly4 81.53% <100%> (+0.01%) ⬆️
#patternflymisc 95.65% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...re/src/components/TextInput/ForwardRefTextInput.js 100% <100%> (ø)
...4/react-core/src/components/TextInput/TextInput.js 91.66% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f12527...633ad03. Read the comment docs.

@dgutride
Copy link
Member

Closing due to no response - please reopen once an issue has been created and accepted for this work to begin.

@dgutride dgutride closed this Mar 18, 2019
@boaz0
Copy link
Member Author

boaz0 commented Mar 18, 2019

@dgutride - I thought you got a notification about rebasing the PR.
is it possible to open this PR again ❓ 🙏

@boaz0 boaz0 deleted the focus_input branch April 24, 2020 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants