-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(TextInput): Add Focus TextInput example #912
Conversation
Pull Request Test Coverage Report for Build 3410
💛 - Coveralls |
PatternFly-React preview: https://912-pr-patternfly-react-patternfly.surge.sh |
packages/patternfly-4/react-core/src/components/TextInput/examples/FocusTextInput.js
Outdated
Show resolved
Hide resolved
packages/patternfly-4/react-core/src/components/TextInput/examples/FocusTextInput.js
Outdated
Show resolved
Hide resolved
@boaz1337 Can you please resolve conflicts in your branch. |
packages/patternfly-4/react-core/src/components/TextInput/examples/FocusTextInput.js
Outdated
Show resolved
Hide resolved
I'm not able to review this. I get a "page not found" error when I try to navigate to the preview. |
@jgiardino yes me too. I guess because tests failed. I will try to fix this soon as possible. Thanks. |
@boaz1337 looks like this one is still failing the build. Could you please take a look at that. Thanks! |
This PR has become stale - it isn't related to any issues we have open. If you'd like to continue forward, please respond before March 18, 2019 and we'll keep it open otherwise we'll close as inactive. |
Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #912 +/- ##
==========================================
+ Coverage 83.86% 83.87% +<.01%
==========================================
Files 556 557 +1
Lines 5857 5859 +2
Branches 12 12
==========================================
+ Hits 4912 4914 +2
Misses 943 943
Partials 2 2
Continue to review full report at Codecov.
|
Closing due to no response - please reopen once an issue has been created and accepted for this work to begin. |
@dgutride - I thought you got a notification about rebasing the PR. |
I added an example of how to focus on
TextInput
.Using
innerRef
props that was added in this change andReact.forwardRef
I could get theinput
component and focus on it.