-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(Masthead): Consume Penta tokens #9853
Conversation
Preview: https://patternfly-react-pr-9853.surge.sh A11y report: https://patternfly-react-pr-9853-a11y.surge.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some slight styling differences I'm noticing which may not necessarily be due to Masthead (the hamburger icon in examples is slightly bigger than Core examples, the link color is slightly different), but otherwise looks good react wise
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Opened #9897 as followup
packages/react-core/src/components/Masthead/examples/MastheadIconRouterLink.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet! Approved
Your changes have been released in:
Thanks for your contribution! 🎉 |
What: Closes #9809
Updated at Masthead demos and examples logos for light variation of masthead.
Note: Masthead:
backgroundColor
prop was removed in PR #9774 since light background is now the default with no option to change it.