Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Masthead): Consume Penta tokens #9853

Merged
merged 2 commits into from
Dec 20, 2023
Merged

Conversation

tlabaj
Copy link
Contributor

@tlabaj tlabaj commented Dec 5, 2023

What: Closes #9809

Updated at Masthead demos and examples logos for light variation of masthead.

Note: Masthead: backgroundColor prop was removed in PR #9774 since light background is now the default with no option to change it.

@tlabaj tlabaj requested review from a team, mfrances17, kmcfaul, mmenestr and mattnolting and removed request for a team December 5, 2023 23:42
@tlabaj tlabaj changed the title Masthead penta chore(Masthead): Consume Penta tokens Dec 5, 2023
@patternfly-build
Copy link
Contributor

patternfly-build commented Dec 5, 2023

Copy link
Contributor

@thatblindgeye thatblindgeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some slight styling differences I'm noticing which may not necessarily be due to Masthead (the hamburger icon in examples is slightly bigger than Core examples, the link color is slightly different), but otherwise looks good react wise

Copy link
Contributor

@mattnolting mattnolting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Opened #9897 as followup

Copy link
Collaborator

@andrew-ronaldson andrew-ronaldson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! Approved

@nicolethoen nicolethoen merged commit 51c3dac into patternfly:v6 Dec 20, 2023
13 checks passed
@patternfly-build
Copy link
Contributor

Your changes have been released in:

  • @patternfly/react-code-editor@6.0.0-alpha.7
  • @patternfly/react-core@6.0.0-alpha.7
  • @patternfly/react-docs@7.0.0-alpha.7
  • demo-app-ts@5.1.1-alpha.6
  • @patternfly/react-table@6.0.0-alpha.7

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Masthead): Add Penta tokens
7 participants