PR feedback

patternfly · Aug 27, 2024 · d9a831c · d9a831c
1 parent e3da442
commit d9a831c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/packages/eslint-plugin-pf-codemods/src/ruleCustomization.ts b/packages/eslint-plugin-pf-codemods/src/ruleCustomization.ts
@@ -24,6 +24,7 @@ export const warningRules = [
   "horizontalSubnav-warn-ariaLabel",
   "jumpLinksItem-warn-markup-change",
   "label-warn-truncated-default",
+  "loginMainHeader-warn-updated-markup",
   "logViewer-moved-styles",
   "menuItemAction-warn-update-markup",
   "menuToggle-warn-iconOnly-toggle",

diff --git a/...eslint-plugin-pf-codemods/src/rules/helpers/nodeMatches/checkMatchingImportDeclaration.ts b/...eslint-plugin-pf-codemods/src/rules/helpers/nodeMatches/checkMatchingImportDeclaration.ts
@@ -16,16 +16,14 @@ function findSpecifier(
 export function checkMatchingImportDeclaration(
   node: ImportDeclaration,
   imports: ImportSpecifier | ImportSpecifier[],
-  exactMatch: boolean = false
+  packageNamne: string = "@patternfly/react-core"
 ) {
-  if (!pfPackageMatches("@patternfly/react-core", node.source.value)) {
+  if (!pfPackageMatches(packageNamne, node.source.value)) {
     return false;
   }
 
   if (Array.isArray(imports)) {
-    return exactMatch
-      ? imports.every((imp) => findSpecifier(node, imp))
-      : imports.some((imp) => findSpecifier(node, imp));
+    return imports.some((imp) => findSpecifier(node, imp));
   }
 
   return findSpecifier(node, imports);