Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add codemod for removing our data-codemod attributes #723

Closed
wise-king-sullyman opened this issue Jul 30, 2024 · 0 comments · Fixed by #745
Closed

Add codemod for removing our data-codemod attributes #723

wise-king-sullyman opened this issue Jul 30, 2024 · 0 comments · Fixed by #745
Assignees
@adamviktora
Labels
codemod
Milestone
Penta final release

Comments

@wise-king-sullyman
Copy link
Collaborator

Consumers would probably appreciate us not littering their code with our data tags, so we should give them a mod to remove them.

It should probably only run when manually called for using the --only flag, or something to that effect.
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Jul 30, 2024
@wise-king-sullyman wise-king-sullyman mentioned this issue Aug 13, 2024
Merged
@thatblindgeye thatblindgeye added this to the Penta final release milestone Aug 13, 2024
@thatblindgeye thatblindgeye moved this from Needs triage to Ready to assign in PatternFly Issues Aug 13, 2024
@adamviktora adamviktora self-assigned this Aug 14, 2024
@adamviktora adamviktora moved this from Ready to assign to Not started in PatternFly Issues Aug 14, 2024
@adamviktora adamviktora moved this from Not started to In Progress in PatternFly Issues Aug 21, 2024
@adamviktora adamviktora mentioned this issue Aug 21, 2024
Merged
@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamviktora adamviktora

Labels
codemod
Projects
PatternFly Issues
Archived in project
Milestone
Penta final release
Development

Successfully merging a pull request may close this issue.

feat: data-codemods cleanup rule adamviktora/pf-codemods
3 participants
@wise-king-sullyman @thatblindgeye @adamviktora