feat: data-codemods cleanup rule #745
Conversation
...ges/eslint-plugin-pf-codemods/src/rules/v6/dataCodemodsCleanup/data-codemods-cleanup.test.ts
Show resolved
Hide resolved
packages/pf-codemods/index.js
Outdated
| // data-codemods-cleanup rule won't be included in the recommended rule set | ||
| delete configs.recommended.rules[prefix + "data-codemods-cleanup"]; | ||
|
|
There was a problem hiding this comment.
Could you not just add the rule to the betaRules array in the customization file instead of adding logic to this file?
There was a problem hiding this comment.
Oh, yeah, I did not read the betaRuleNames description, the name "beta" confused me a bit
There was a problem hiding this comment.
FWIW Austin and I had a convo about the naming of the array, though I don't think we settled on whether to change it (or to what if so). Maybe post v6 we can have a brainstorm session about that + anything else we'd like to see changed in the repo
| import { | ||
| DualListSelector, | ||
| LoginMainFooterLinksItem, | ||
| MastheadLogo, | ||
| } from "@patternfly/react-core"; | ||
|
|
||
| export const DataCodemodsCleanupInput = () => ( | ||
| <> | ||
| <DualListSelector /> | ||
| <LoginMainFooterLinksItem /> | ||
| <MastheadLogo /> | ||
| </> | ||
| ); |
There was a problem hiding this comment.
Looks like the output file had the formatter ran on it after execution. Doesn't really matter now, but will if we ever implement auto checking of these tsx files in CI.
There was a problem hiding this comment.
Oops, I thought we should run prettier on these output files, I do it every time 🤦
adamviktora
force-pushed
the
data-codemods-cleanup
branch
from
4c9da6c to
6a2f521
Compare
Closes #723
Also updates
baseReadme.mdfile.