feat(Masthead): Remove backgroundColor prop #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,16 @@ | |||
| import { renameProps } from '../../helpers'; | |||
|
|
|||
| // https://github.com/patternfly/patternfly-react/pull/9744 | |||
There was a problem hiding this comment.
PR number should be 9774
Comment on lines
5
to
9
| valid: [ | ||
| { | ||
| code: `<Masthead backgroundColor />` | ||
| } | ||
| ], |
There was a problem hiding this comment.
Do we still want to include valid cases like this:
{
code: `import { Masthead } from '@patternfly/react-core'; <Masthead someOtherProp />`
}
to ensure the rule doesn't flag an error unexpectedly
| ], | ||
| invalid: [ | ||
| { | ||
| code: `import { Masthead } from '@patternfly/react-core'; <Masthead backgroundColor />`, |
There was a problem hiding this comment.
Maybe an invalid test where we pass a value to backgroundColor, just to sanity check it still gets removed.
| @@ -0,0 +1,18 @@ | |||
| ### masthead-remove-background-color [(#9744)](https://github.com/patternfly/patternfly-react/pull/9744) | |||
There was a problem hiding this comment.
PR number needs updating here as well
thatblindgeye
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #542