-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(FormGroup): rename labelIcon to labelHelp #581
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment below. Agreed that we shouldn't try to update code to render FormGroupLabelHelp, that should be on the consumer once they're made aware of the update + our recommendation.
As for adding a comment inline with wherever the labelHelp prop is, I'd probably lean towards not doing that, since it's clutter being added to consumer code that may not be necessary. The consumer could already have their own component being passed that is essentially our FormGroupLabelHelp or something, and the error message will already recommend it which I think should be good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit and agree with @thatblindgeye's thoughts above, nothing blocking that I see though.
...-plugin-pf-codemods/src/rules/v6/formGroupRenameLabelIcon/formGroup-rename-labelIcon.test.ts
Outdated
Show resolved
Hide resolved
...slint-plugin-pf-codemods/src/rules/v6/formGroupRenameLabelIcon/formGroup-rename-labelIcon.md
Outdated
Show resolved
Hide resolved
d7ddf56
to
d1d35f9
Compare
Closes #563
Wait until the underlying react PR patternfly/patternfly-react#10016 is approved and merged before merging this codemod PR.
Possible improvements / thoughts:
labelIcon
to use the new FormGroupLabelHelp component is nearly impossible and there would be lots of edge cases, so I would rather not do thatFormGroupLabelHelp
component for thelabelHelp
prop? Something like:input:
output:
or is a message in the codemod error sufficient?