Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(UnavailableContent): update props to use bodyText #737

Merged

Conversation

adamviktora
Copy link
Contributor

Closes #732

  • because unavailableBodyPreStatusLinkText and unavailableBodyPostStatusLinkText has already been renamed to preLinkBodyText and postLinkBodyText and are being renamed again and merged to only one bodyText prop, I also modified the component-groups-unavailable-content-rename-props rule to only rename unavailableTitleText
  • statusPageLinkText prop is now being used for a primary button instead of a link button -> the text should be capitalized (as it is being done with the default "status page" -> "Status page")

Copy link
Collaborator

@wise-king-sullyman wise-king-sullyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@thatblindgeye thatblindgeye merged commit 045a156 into patternfly:main Aug 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[component-groups] - UnavailableContent
3 participants