feat(tokens): warn about old react-tokens usage #739
Conversation
|
|
||
| const { imports: tokenSpecifiers } = getFromPackage(context, tokensPackage); | ||
|
|
||
| const defaultTokensWithDeclaration = getDefaultImportsFromPackage( |
There was a problem hiding this comment.
Think this might be something worth helperizing?
There was a problem hiding this comment.
I don't know if we ever use it again, I feel like it is quite specific. Do you have some potential future use case on your mind?
There was a problem hiding this comment.
To clarify I don't mean for tokens explicitly, but something that returns the default imports file name and the import declaration in a nice easy to use format like this.
I feel like I've had a few places where it would've been nice so far, though I haven't dug through to find what those instances were. If you don't think it would likely be helpful it's always something we can revisit in the future if it turns out the other way.
There was a problem hiding this comment.
Yeah, you are right, I also ran to something similar maybe on the component-groups. I lean towards creating the helper as a followup, if we run to a problem where it would be helpful
packages/eslint-plugin-pf-codemods/src/rules/v6/tokensWarn/tokens-warn.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Eric Olkowski <70952936+thatblindgeye@users.noreply.github.com>
|
Also, we should maybe not only check react-tokens, but also raw strings having the token values in the codebase. We could also check CSS files, but that probably is not achievable by ESLint. |
Closes #733