Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: get rid of nodeIsComponentNamed helper #746

Merged
merged 1 commit into from
Aug 26, 2024
Merged

refactor: get rid of nodeIsComponentNamed helper #746

merged 1 commit into from
Aug 26, 2024

Conversation

adamviktora
Copy link
Contributor

Closes #744

thatblindgeye
thatblindgeye reviewed Aug 22, 2024
View reviewed changes
Copy link
Collaborator

@thatblindgeye thatblindgeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the nodeIsComponentNamed file itself and export just need to be removed

@adamviktora
Copy link
Contributor Author

@thatblindgeye I'll wait on yours #738 to merge, where you did the refactoring, because here the nodeIsComponentNamed is still in the JSXElements.ts file with other helpers. I'll then rebase and delete the separate nodeIsComponentNamed.ts file

@adamviktora adamviktora force-pushed the remove-nodeIsComponentNamed branch from 61c9783 to f4b868d Compare August 26, 2024 13:44
@thatblindgeye thatblindgeye merged commit b0fa2b2 into patternfly:main Aug 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thatblindgeye thatblindgeye thatblindgeye approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove nodeIsComponentNamed helper - refactor usage with checkMatchingJSXOpeningElement
2 participants
@adamviktora @thatblindgeye