Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tokens): provide autofix for all global tokens #763

Merged
merged 8 commits into from
Sep 24, 2024

Conversation

adamviktora
Copy link
Contributor

@adamviktora adamviktora commented Sep 10, 2024

Closes #748

Provides an autofix for both the non-color and color global tokens.

There could be a problem when importing the temp_dev_tbd token, if consumers are using an old version of patternfly - it has been added recently in one of the newest post beta versions.

Copy link
Collaborator

@wise-king-sullyman wise-king-sullyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two nits, and I wonder if we should change this rule name since it's no longer a warning, but nothing I'd block over.

Absolutely awesome work on this! 🚀 🚀 🚀

@adamviktora adamviktora marked this pull request as draft September 12, 2024 14:58
@adamviktora adamviktora marked this pull request as draft September 12, 2024 14:58
@adamviktora adamviktora marked this pull request as draft September 12, 2024 14:58
@adamviktora adamviktora marked this pull request as ready for review September 12, 2024 15:01
@adamviktora adamviktora changed the title feat(tokens): provide autofix for global non-color tokens feat(tokens): provide autofix for all global tokens Sep 17, 2024
Co-authored-by: Eric Olkowski <70952936+thatblindgeye@users.noreply.github.com>
Copy link
Collaborator

@wise-king-sullyman wise-king-sullyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🔥 🔥 absolutely AWESOME work on this!

@wise-king-sullyman wise-king-sullyman merged commit f5d32ce into patternfly:main Sep 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New CSS tokens - warn and do a mapping for global tokens
4 participants