-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tokens): provide autofix for all global tokens #763
feat(tokens): provide autofix for all global tokens #763
Conversation
0cf6435
to
973e700
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two nits, and I wonder if we should change this rule name since it's no longer a warning, but nothing I'd block over.
Absolutely awesome work on this! 🚀 🚀 🚀
packages/eslint-plugin-pf-codemods/src/rules/v6/tokensWarn/tokens-warn.ts
Outdated
Show resolved
Hide resolved
packages/eslint-plugin-pf-codemods/src/rules/v6/tokensWarn/tokens-warn.ts
Outdated
Show resolved
Hide resolved
packages/eslint-plugin-pf-codemods/src/rules/v6/tokensUpdate/tokens-update.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Eric Olkowski <70952936+thatblindgeye@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 🔥 🔥 absolutely AWESOME work on this!
Closes #748
Provides an autofix for both the non-color and color global tokens.
There could be a problem when importing the
temp_dev_tbd
token, if consumers are using an old version of patternfly - it has been added recently in one of the newest post beta versions.