Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Basic example #19

Merged
merged 4 commits into from
Dec 5, 2023

Conversation

jenny-s51
Copy link
Collaborator

@jenny-s51 jenny-s51 commented Nov 9, 2023

Removes deprecated references to v4 table.

Converted Basic example to TSX/function components and refactored to use new PF5 Table

Towards #17 and #14

Addressed one type error in the example itself and slightly tweaked the
types for the virtual table to accommodate a role prop.
Copy link
Collaborator

@wise-king-sullyman wise-king-sullyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything other than the couple things I addressed in my commit below look great 🚀

Copy link
Contributor

@dlabaj dlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wise-king-sullyman wise-king-sullyman merged commit b62b369 into patternfly:v6 Dec 5, 2023
4 checks passed
Copy link

github-actions bot commented Jun 3, 2024

🎉 This PR is included in version 1.0.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

🎉 This PR is included in version 6.0.0-prerelease.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants