-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Basic example #19
Conversation
Addressed one type error in the example itself and slightly tweaked the types for the virtual table to accommodate a role prop.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything other than the couple things I addressed in my commit below look great 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🎉 This PR is included in version 1.0.0-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 6.0.0-prerelease.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Removes deprecated references to v4 table.
Converted Basic example to TSX/function components and refactored to use new PF5 Table
Towards #17 and #14