Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qualify statement bug fixes #34

Merged
merged 4 commits into from
Aug 17, 2022
Merged

Qualify statement bug fixes #34

merged 4 commits into from
Aug 17, 2022

Conversation

mattbrown-msb
Copy link
Contributor

Description

This PR consists of two small bug fixes around generating qualify statements and the qualifed_results cte in the sql_manipulator.rb.

  1. If the "select" index is 0, then the statement should be "WITH qualified_results as (".
  2. Update the order in which the having and the qualify statements are injected into the query to ensure that the 'qualify' statement is after 'having'.

vishalzambre
vishalzambre approved these changes Aug 17, 2022
View reviewed changes
Copy link
Contributor

@vishalzambre vishalzambre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Once it is merged Need to test few changes as we had some issues in past. I'll get them tested with @ahujaak as he worked

@mattbrown-msb mattbrown-msb merged commit e38eb7a into master Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishalzambre vishalzambre vishalzambre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattbrown-msb @vishalzambre