Relax faraday dep
#3
Conversation
| @@ -35,6 +35,7 @@ Gem::Specification.new do |spec| | |||
| # For more information and examples about making a new gem, check out our | |||
| # guide at: https://bundler.io/guides/creating_gem.html | |||
|
|
|||
| spec.add_dependency "faraday", "~> 2.7" | |||
| spec.add_dependency "faraday", "~> 1" | |||
There was a problem hiding this comment.
Seems like adding faraday_middleware may prevent installing faraday 2.0.1 or higher.
Is there a reason this gem needs to keep support for versions less than 2.0? Could we use ~> 2.0.1 and drop faraday_middleware as a dependency?
There was a problem hiding this comment.
Yeah I think the move is to bump it to faraday >2 everywhere. When I say "everywhere" I mean all of the other gems also required by langchainrb.
There was a problem hiding this comment.
Some are already allowing for 2.0.1 and higher:
- replicate-ruby: ">= 1.0"
- hugging-face: ">= 1.0"
- anthropic: ">= 1"
- ruby-openai: ">= 1"
This one had an outstanding pull request already:
- open-weather-ruby-client: outstanding PR
Created MRs for these:
- cohere-ruby: Updates faraday dependency cohere-ruby#6
- google_palm_api: Updates faraday dependency google_palm_api#4
- milvus: Updates faraday dependency milvus#5
- qdrant-ruby: Updates faraday dependency #4
- weaviate-ruby: Updates faraday dependency weaviate-ruby#31
There was a problem hiding this comment.
@rthbound I've released new versions for all of these gems. Would you like to try bumping up the dependencies on Langchain.rb?
There was a problem hiding this comment.
Looks like we'll still need to wait for the open-weather-ruby-client gem to merge before we can update Langchain.rb's gemspec to specify the latest versions of these gems. If we update sooner, then bundle install won't run successfully within the langchain project.
There was a problem hiding this comment.
@rthbound Looks like we're all set!
There was a problem hiding this comment.
@rthbound I went ahead and bumped the gems versions: patterns-ai-core/langchainrb#302
No description provided.