Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update peerDependencies for react 16 #189

Closed
nassimbenkirane opened this issue Jan 15, 2018 · 4 comments
Closed

Update peerDependencies for react 16 #189

nassimbenkirane opened this issue Jan 15, 2018 · 4 comments

Comments

@nassimbenkirane
Copy link

Hello !

Thanks for this library 👍
When using react-intl-tel-input with react16, yarn gives me those warnings :

warning " > react-intl-tel-input@4.3.1" has incorrect peer dependency "prop-types@~15.5.8".
warning " > react-intl-tel-input@4.3.1" has incorrect peer dependency "react@^15.4.2".
warning " > react-intl-tel-input@4.3.1" has incorrect peer dependency "react-dom@^15.4.2".

Would it be possible to update the dependencies ? Are they known issues with React 16 that prevents this ?

Thanks a lot :)

@nassimbenkirane
Copy link
Author

PS, I can do a PR if you want

@patw0929
Copy link
Owner

patw0929 commented Jan 16, 2018

Ah, sorry for the late reply, I would appreciate it if you could help. 😄
I think it might be a breaking change to upgrade to react 16.

Thank you! 👍

@patw0929
Copy link
Owner

patw0929 commented Mar 8, 2018

Already merge #196 and released as v5.0.0 to support react 16.
If it still has problem, please reopen this issue, thanks!

@patw0929 patw0929 closed this as completed Mar 8, 2018
@nassimbenkirane
Copy link
Author

Ah, sorry I didn't reply earlier !

Thanks a lot for the update 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants