-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to React 16 #196
Upgrade to React 16 #196
Conversation
Thank you for this PR! I've leave some comment above. |
Hi guys, sorry for bumping this issue.. anything I can do to help move this PR forward? would be nice to have this library be react 16 compatible, since it is currently the last package holding us from upgrading to react 16.. |
Hey @ignatiusreza, I was stuck after updating this branch (from master) to resolve the merge conflicts. I couldn't get the changes from #195 working in the test suite. Would you be able to try on your side? |
managed to make it pass with react-16 https://github.com/ignatiusreza/react-intl-tel-input/tree/upgrade/react @puffo do you mind if I open another PR? |
Thanks for your help @ignatiusreza! I've pushed up the changes and cleaned up as per the changes on your fork. I'm now struggling with the Travis CI build, but it looks like it the build isn't pulling from my branch. Not sure if you can help out here @patw0929 or @ignatiusreza ? |
@puffo @ignatiusreza Thank you bros! Awesome! |
Build is now green @patw0929 ! Thanks! |
Breaking change: * #196 Upgrade to React 16 (by @puffo & @ignatiusreza)
"npm": "^5.6.0", | ||
"raf": "^3.4.0", | ||
"react": "^16.2.0", | ||
"react-dom": "^16.2.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for the late comment.. but I think these dependencies should not be forced unto the users:
react
andreact-dom
is already mentioned as peerDependencies,npm
is not used, not sure why it's there in the first placeenzyme-adapter-react-16
is only used for development, and user does not necessarily test their code usingenzyme
raf
is not the only option for polyfillingrequestAnimationFrame
.. user might already do it through other method.. and ifreact
them self doesn't force one particular way to polyfill it, I don't think that we should too..
opened a PR to fix these points: #199
Upgrade to React 16
Breaking change: * patw0929#196 Upgrade to React 16 (by @puffo & @ignatiusreza)
Hi there!
This upgrades the project to React 16 (#189).
Enzyme 3 requires that we re-find elements that might have changed (see this discussion). It has resulted in some of the tests looking a bit clunkier in that we unfortunately can't instantiate all the necessary variables at the start of the tests.
I'll need some help to finish it up though - in attempting to merge the latest changes from #195, I can't seem to get the most recent test passing.
Any suggestions/help?