-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: highlight country from preferred list #192
Conversation
I would like to add a unit test, but I have an error after
@patw0929, Do you know what can be a problem? |
Awesome! Thank you 👍 The missing module error of react when running test, please install peer dependency packages by following command: yarn add react@^15.4.2 react-dom@^15.4.2 prop-types@~15.5.8 --peer |
@patw0929 it works, thanks. I will add a test. |
I added a small test, @patw0929 could you pls take a look? ;) |
LGTM 💯 |
fix: highlight country from preferred list
Bug fixes: * patw0929#192: highlight country from preferred list (by @Denis-K)
When we define a
preferredCountries
property, we have a list of the preferred countries on the top of the drop-down menu. But when we open a drop-down, the selected country by default will be in general list, not in apreferredCountries
list. See a demo:In this case,
preferredCountries
is hidden from the user. He will not expect to find it and will not look for it.Instead, let's try to select a country from the
preferredCountries
list. See a demo: