-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle placeholder and customPlaceholder change #204
Conversation
There are some eslint errors:
Could you help to fix it and make sure the test cases have been cover the modification? |
Hey, I fixed the linting and added some tests, but they're not passing yet. Could you please help me a bit on this? I have little experience with React components testing. Thanks 👍 |
|
||
it('should change input placeholder on customPlaceholder prop change', () => { | ||
const subject = this.makeSubject(); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add:
requests[0].respond(200,
{ 'Content-Type': 'text/javascript' },
libphonenumberUtils);
window.eval(getScript().text);
Because the setState
in updatePlaceholder
will execute only when window.intlTelInputUtils
is not undefined.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be good, thanks!
Bug fix: * #204: Handle placeholder and customPlaceholder change (by @adrienharnay)
Handle placeholder and customPlaceholder change
Bug fix: * patw0929#204: Handle placeholder and customPlaceholder change (by @adrienharnay)
Fixes #203