Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cursor Issue#205 #221

Merged
merged 1 commit into from
Jul 7, 2018
Merged

Fix cursor Issue#205 #221

merged 1 commit into from
Jul 7, 2018

Conversation

superhit0
Copy link
Collaborator

Fixing Cursor Issue#205

@patw0929

@superhit0 superhit0 requested a review from patw0929 July 1, 2018 09:27
@coveralls
Copy link

coveralls commented Jul 1, 2018

Coverage Status

Coverage decreased (-0.2%) to 94.053% when pulling da17ddb on superhit0:cursor-fix into a8c8808 on patw0929:master.

@patw0929
Copy link
Owner

patw0929 commented Jul 1, 2018

Thanks!
But I met some weird cases:

  1. At demo page, select Taiwan first, and enter word by word: 0912345678. The cursor will not after the 8 after enter the 8.
  2. At demo page too. Select Taiwan, and enter word by word: +886912345678. The + plus sign will at the end of string.

@superhit0
Copy link
Collaborator Author

Yeah, thanks for pointing it out. Will revamp the algorithm.

@superhit0
Copy link
Collaborator Author

@patw0929 I have fixed the algorithm.
Can you please check it & confirm?
Thanks

@patw0929
Copy link
Owner

patw0929 commented Jul 2, 2018

Looks good to me! 👍

@superhit0
Copy link
Collaborator Author

@patw0929 Can we merge it?

@patw0929
Copy link
Owner

patw0929 commented Jul 3, 2018

Oh sorry, I found another weird case: 😢

image

When I press backspace at the end of an us phone number, it will left some part.

@superhit0
Copy link
Collaborator Author

@patw0929 Can you please check now?

@patw0929
Copy link
Owner

patw0929 commented Jul 7, 2018

@superhit0 Looks great! Thanks!

@superhit0
Copy link
Collaborator Author

@patw0929 If its ok, Can we merge it?
Or should we do more tests?

@patw0929
Copy link
Owner

patw0929 commented Jul 7, 2018

Yes, we can merge it first.

@superhit0 superhit0 merged commit 04a83ab into patw0929:master Jul 7, 2018
@superhit0 superhit0 deleted the cursor-fix branch July 15, 2018 11:20
andrewsantarin pushed a commit to andrewsantarin/react-intl-tel-input that referenced this pull request Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants